Validate branch with prompt #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
@joshdholtz got hit by this yesterday so this is a good change
tonidero
force-pushed
the
validate-branch-with-prompt
branch
from
dff65f0
to
cc85bd7
Compare
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the automatic branch validation to
mainwe do during thebump_version_update_changelog_create_praction. Instead, we will prompt the user to confirm that the current branch is the one intended to be the base of the bump.