CustomEntitlementsComputation: Prevent posting subscriber attributes …

…in post receipt (#1151) Prevents sending subscriber attributes when posting receipts in custom entitlements computation mode.
RevenueCat · Jul 20, 2023 · 6ec7485 · 6ec7485
1 parent 46321d2
commit 6ec7485
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/purchases/src/main/kotlin/com/revenuecat/purchases/common/Backend.kt b/purchases/src/main/kotlin/com/revenuecat/purchases/common/Backend.kt
@@ -198,7 +198,7 @@ internal class Backend(
             "observer_mode" to observerMode,
             "price" to receiptInfo.price,
             "currency" to receiptInfo.currency,
-            "attributes" to subscriberAttributes.takeUnless { it.isEmpty() },
+            "attributes" to subscriberAttributes.takeUnless { it.isEmpty() || appConfig.customEntitlementComputation },
             "normal_duration" to receiptInfo.duration,
             "store_user_id" to storeAppUserID,
             "pricing_phases" to receiptInfo.pricingPhases?.map { it.toMap() },

diff --git a/purchases/src/test/java/com/revenuecat/purchases/common/BackendTest.kt b/purchases/src/test/java/com/revenuecat/purchases/common/BackendTest.kt
@@ -85,6 +85,7 @@ class BackendTest {
     private val mockAppConfig: AppConfig = mockk<AppConfig>().apply {
         every { baseURL } returns mockBaseURL
         every { diagnosticsURL } returns mockDiagnosticsBaseURL
+        every { customEntitlementComputation } returns false
     }
     private val dispatcher = SyncDispatcher()
     private val backendHelper = BackendHelper(API_KEY, dispatcher, mockAppConfig, mockClient)

diff --git a/...st/java/com/revenuecat/purchases/subscriberattributes/SubscriberAttributesBackendTests.kt b/...st/java/com/revenuecat/purchases/subscriberattributes/SubscriberAttributesBackendTests.kt
@@ -42,6 +42,7 @@ class SubscriberAttributesPosterTests {
     private val mockBaseURL = URL("http://mock-api-test.revenuecat.com/")
     private val mockAppConfig = mockk<AppConfig>().apply {
         every { baseURL } returns mockBaseURL
+        every { customEntitlementComputation } returns false
     }
     private val appUserID = "jerry"
     private val dispatcher = SyncDispatcher()
@@ -316,6 +317,32 @@ class SubscriberAttributesPosterTests {
         assertThat(actualPostReceiptBody["attributes"]).isNotNull
     }
 
+    @Test
+    fun `posting receipt with attributes skips them in custom entitlements computation mode`() {
+        every { mockAppConfig.customEntitlementComputation } returns true
+        mockPostReceiptResponse()
+
+        val productInfo = ReceiptInfo(
+            productIDs = listOf(productID)
+        )
+        backend.postReceiptData(
+            purchaseToken = fetchToken,
+            appUserID = appUserID,
+            isRestore = false,
+            observerMode = false,
+            subscriberAttributes = mapOfSubscriberAttributes,
+            receiptInfo = productInfo,
+            storeAppUserID = null,
+            onSuccess = expectedOnSuccessPostReceipt,
+            onError = unexpectedOnErrorPostReceipt
+        )
+
+        assertThat(receivedCustomerInfo).isNotNull
+        val actualPostReceiptBody = actualPostReceiptBodySlot.captured
+        assertThat(actualPostReceiptBody).isNotNull
+        assertThat(actualPostReceiptBody.containsKey("attributes")).isFalse
+    }
+
     @Test
     fun `posting receipt without attributes skips them`() {
         mockPostReceiptResponse()