Disable offline entitlements in custom entitlements computation mode (#…

…1146) ### Description Offline entitlements aren't needed in custom entitlements computation mode so this PR disables it in that mode.
RevenueCat · Jul 19, 2023 · 9deb1a8 · 9deb1a8
1 parent 492e97c
commit 9deb1a8
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/.../kotlin/com/revenuecat/purchases/common/offlineentitlements/OfflineEntitlementsManager.kt b/.../kotlin/com/revenuecat/purchases/common/offlineentitlements/OfflineEntitlementsManager.kt
@@ -114,7 +114,9 @@ internal class OfflineEntitlementsManager(
 
     // We disable offline entitlements in observer mode (finishTransactions = true) since it doesn't
     // provide any value and simplifies operations in that mode.
-    private fun isOfflineEntitlementsEnabled() = appConfig.finishTransactions && appConfig.enableOfflineEntitlements
+    private fun isOfflineEntitlementsEnabled() = appConfig.finishTransactions &&
+        appConfig.enableOfflineEntitlements &&
+        !appConfig.customEntitlementsComputation
 }
 
 private typealias OfflineCustomerInfoCallback = Pair<(CustomerInfo) -> Unit, (PurchasesError) -> Unit>
diff --git a/...ava/com/revenuecat/purchases/common/offlineentitlements/OfflineEntitlementsManagerTest.kt b/...ava/com/revenuecat/purchases/common/offlineentitlements/OfflineEntitlementsManagerTest.kt
@@ -60,6 +60,9 @@ class OfflineEntitlementsManagerTest {
         every {
             appConfig.finishTransactions
         } returns true
+        every {
+            appConfig.customEntitlementsComputation
+        } returns false
         every {
             appConfig.enableOfflineEntitlements
         } returns true
@@ -142,6 +145,18 @@ class OfflineEntitlementsManagerTest {
         assertThat(result).isFalse
     }
 
+    @Test
+    fun `shouldCalculateOfflineCustomerInfoInGetCustomerInfoRequest returns false if custom entitlement computation`() {
+        every { deviceCache.getCachedCustomerInfo(appUserID) } returns null
+        every { appConfig.customEntitlementsComputation } returns true
+        val isServerError = true
+        val result = offlineEntitlementsManager.shouldCalculateOfflineCustomerInfoInGetCustomerInfoRequest(
+            isServerError,
+            appUserID
+        )
+        assertThat(result).isFalse
+    }
+
     // endregion
 
     // region shouldCalculateOfflineCustomerInfoInPostReceipt
@@ -172,6 +187,13 @@ class OfflineEntitlementsManagerTest {
         assertThat(offlineEntitlementsManager.shouldCalculateOfflineCustomerInfoInPostReceipt(isServerError)).isFalse
     }
 
+    @Test
+    fun `shouldCalculateOfflineCustomerInfoInPostReceipt returns false if custom entitlements computation mode`() {
+        every { appConfig.customEntitlementsComputation } returns true
+        val isServerError = true
+        assertThat(offlineEntitlementsManager.shouldCalculateOfflineCustomerInfoInPostReceipt(isServerError)).isFalse
+    }
+
     // endregion
 
     // region resetOfflineCustomerInfoCache
@@ -404,6 +426,13 @@ class OfflineEntitlementsManagerTest {
         verify(exactly = 1) { deviceCache.cacheProductEntitlementMapping(expectedMappings) }
     }
 
+    @Test
+    fun `updateProductEntitlementMappingCacheIfStale does nothing in custom entitlement computation mode`() {
+        every { appConfig.customEntitlementsComputation } returns true
+        offlineEntitlementsManager.updateProductEntitlementMappingCacheIfStale()
+        verify(exactly = 0) { backend.getProductEntitlementMapping(any(), any()) }
+    }
+
     // endregion
 
     // region helpers