Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom entitlements: add README and other improvements #1167

Merged
merged 26 commits into from
Jul 24, 2023
Merged

Custom entitlements: add README and other improvements #1167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6002092
remove amazon, actually use custom entitlements mode
aboedo Jul 21, 2023
339223c
removed trusted entitlements from this mode
aboedo Jul 21, 2023
0e843f1
more updates to readme
aboedo Jul 21, 2023
6825799
made things internal instead of removing them
aboedo Jul 21, 2023
3573b01
removed trusted entitlements from API tests
aboedo Jul 21, 2023
ce6f417
remove unused import
aboedo Jul 21, 2023
38e2ec1
fix adding dependency README section
vegaro Jul 24, 2023
f40ebfa
update to Purchases.configureInCustomEntitlementsComputationMode
vegaro Jul 24, 2023
6b777fe
comment out includeBuild
vegaro Jul 24, 2023
226c82c
better error handling
vegaro Jul 24, 2023
883202b
update artifact id
vegaro Jul 24, 2023
f99c646
renames in readme
vegaro Jul 24, 2023
83c5a09
comment out includebuild
vegaro Jul 24, 2023
3865342
update screenshot
vegaro Jul 24, 2023
ff0ae38
update PurchasesErrorCode.ProductAlreadyPurchasedError message
vegaro Jul 24, 2023
2c231e2
updates padding so column doesn't change with
vegaro Jul 24, 2023
e50c7dc
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
bd54564
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
86b7ab6
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
d2fe571
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
36ea52a
rename screenshot
vegaro Jul 24, 2023
2d2a10e
update description of Purchases.sharedInstance.updatedCustomerInfoLis…
vegaro Jul 24, 2023
cb2e4c4
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
240bb4b
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
5468bc2
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
205bd91
Update examples/CustomEntitlementComputationSample/README.md
vegaro Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...ntComputationSample/app/src/main/java/com/revenuecat/sample/main/CustomerInfoEventList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ data class CustomerInfoEvent(
)

@Composable
fun CustomerInfoEventsList(events: List<CustomerInfoEvent>, onEventClicked: (CustomerInfoEvent) -> Unit) {
fun CustomerInfoEventsList(
events: List<CustomerInfoEvent>,
onEventClicked: (CustomerInfoEvent) -> Unit
) {
LazyColumn {
items(events) { event ->
CustomerInfoEventsListItem(event = event, onEventClicked = onEventClicked)
Expand All @@ -38,7 +41,10 @@ fun CustomerInfoEventsList(events: List<CustomerInfoEvent>, onEventClicked: (Cus
}

@Composable
fun CustomerInfoEventsListItem(event: CustomerInfoEvent, onEventClicked: (CustomerInfoEvent) -> Unit) {
fun CustomerInfoEventsListItem(
event: CustomerInfoEvent,
onEventClicked: (CustomerInfoEvent) -> Unit
) {
Column(
modifier = Modifier
.clickable { onEventClicked(event) }
Expand Down
4 changes: 1 addition & 3 deletions ...omEntitlementComputationSample/app/src/main/java/com/revenuecat/sample/main/MainScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ fun MainScreen(
Box(
contentAlignment = Alignment.TopStart,
) {
Column {

Column(modifier = Modifier.fillMaxWidth().padding(32.dp)) {
Copy link
Contributor

@vegaro vegaro Jul 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this because the width changed when the list got it first item. It got wider because the content was wider and had a weird spacing, like in this screenshot:

image

Text(
text = "CustomerInfo listener values",
fontSize = 16.sp,
Expand All @@ -196,7 +195,6 @@ fun MainScreen(
color = Color.Black,
textAlign = TextAlign.Center,
)

CustomerInfoEventsList(
uiState.value.customerInfoList,
onEventClicked = { customerInfoEvent ->
Expand Down