-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
presentPaywallIfNeeded always return Null #886
Comments
👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out! |
Hi @imSaharukh, thanks for reporting this. Indeed this is a problem in the current beta of paywalls. We're working on a fix and will update this issue once it's shipped. In the meantime, we suggest handling this error as a non-fatal exception. Not ideal, but we hope to have it fixed soon. |
Same here. BTW are you going to make it possible to use a paywall from different offerings rather than the current one? |
Thanks for reporting! A few questions:
Looking at the code, if this is Android only, I believe what might be happening is that your I just updated the implementation so an error is forwarded instead: 704bd67 |
) ### Description This adds a new method to the `PaywallViewControllerDelegate` to indicate when the `PaywallViewController` is dismissed. This will be useful to listen to responses in the hybrids, since we need to present the paywall and wait until it's been purchased/dismissed before returning a value for the hybrids. This will be needed to fix: RevenueCat/purchases-flutter#886
This allows to set a `PaywallViewControllerDelegate` to the `PaywallProxy` to allow to receive purchase events in the hybrids. This is a first step to fix: RevenueCat/purchases-flutter#886 ### TODO - [x] Expose a delegate method that gets called when the PaywallViewController gets dismissed.
Hi everyone! We're aware of this issue. #916 should fix it temporarily by removing the return value from |
Hi @BorisKest, sorry for missing this! Yeah, that's part of the roadmap but might not be in V1 of paywalls for flutter. |
Currently the `presentPaywall` and `presentPaywallIfNeeded` methods return a boolean indicating whether a purchase happened in the paywall. This API is confusing and not extensible and it wasn't properly working in iOS, see: #886. This first PR removes the return value from the method. In a future PR we will add proper result handling for the paywalls. Until then, the clients won't know what happened when the paywall was presented and will need to rely on the `Purchases.getCustomerInfo()` method to respond appropriately. This is a breaking change from the previous beta.
i'm always getting flutter: type 'Null' is not a subtype of type 'FutureOr' error
The text was updated successfully, but these errors were encountered: