Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOMATIC BUMP] Updates purchases-hybrid-common to 7.4.0 #871

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

RCGitBot
Copy link
Contributor

This is an automatic bump.

Updates purchases-hybrid-common to 7.4.0

@RCGitBot RCGitBot added pr:force_minor Change should force a minor release pr:phc_dependencies labels Nov 17, 2023
@RCGitBot RCGitBot requested a review from a team November 17, 2023 16:40
@@ -244,7 +244,8 @@ - (void)setupPurchases:(NSString *)apiKey
platformFlavorVersion:self.platformFlavorVersion
usesStoreKit2IfAvailable:usesStoreKit2IfAvailable
dangerousSettings:nil
shouldShowInAppMessagesAutomatically:shouldShowInAppMessagesAutomatically];
shouldShowInAppMessagesAutomatically:shouldShowInAppMessagesAutomatically
entitlementVerificationMode:""];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have exposed this as an enum instead of a string.

Copy link
Contributor

@tonidero tonidero Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... We are not usually exposing plain enums in PHC, so we convert most of them to strings/ints... But I guess we could still expose this as enums...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this will come from a Flutter enum anyway, so it's fine for now 👍🏻

@tonidero tonidero merged commit d007ae9 into main Nov 17, 2023
8 checks passed
@tonidero tonidero deleted the bump-phc/7.4.0 branch November 17, 2023 17:41
tonidero pushed a commit that referenced this pull request Nov 23, 2023
**This is an automatic release.**

### New Features
* `Trusted Entitlements`: add support for setting
`EntitlementVerificationMode` and getting verification result in
`EntitlementInfos` and `EntitlementInfo` (#753) via NachoSoto
(@NachoSoto)
### Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 8.0.0 (#878) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.2.4](https://github.com/RevenueCat/purchases-android/releases/tag/7.2.4)
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 7.4.0 (#871) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.2.4](https://github.com/RevenueCat/purchases-android/releases/tag/7.2.4)
* Bump fastlane from 2.216.0 to 2.217.0 (#865) via dependabot[bot]
(@dependabot[bot])
* Bump danger from 9.3.2 to 9.4.0 (#866) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Fix flutter analyze deprecation warnings (#872) via Toni Rico
(@tonidero)
* `CI`: disable `prepare-next-version` (#869) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:force_minor Change should force a minor release pr:phc_dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants