IntegrationTests: actually fail test if tests aren't configured
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like calling `XCTFail` followed by throwing an error was making the test continue for some reason, which was then making it crash instead because `Purchases.shared` isn't set. By removing the `XCTFail`, `XCTest` now correctly sees this as a test failure and doesn't run the tests.
NachoSoto
added a commit
to RevenueCat/purchases-ios
that referenced
this pull request
Aug 19, 2022
Looks like calling `XCTFail` followed by throwing an error was making the test continue for some reason, which was then making it crash instead because `Purchases.shared` isn't set. By removing the `XCTFail`, `XCTest` now correctly sees this as a test failure and doesn't run the tests. See also RevenueCat/purchases-hybrid-common#210
taquitos
approved these changes
Aug 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like calling
XCTFailfollowed by throwing an error was making the test continue for some reason, which was then making it crash instead becausePurchases.sharedisn't set.By removing the
XCTFail,XCTestnow correctly sees this as a test failure and doesn't run the tests.