Fix deploy android circleci job #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
approved these changes
Nov 13, 2023
tonidero
added a commit
that referenced
this pull request
Nov 13, 2023
As part of #552, we added sdkman to install the correct java version. However, the deploy job in CircleCI runs in the root folder, as opposed to the test/lint jobs, which run in the `android` folder, so it wasn't actually installing the correct java version because there was no `.sdkmanrc` file in the root folder and was causing the deploy job to fail, as seen in [PR 557](https://app.circleci.com/pipelines/github/RevenueCat/purchases-hybrid-common/2622/workflows/e6029d52-84ae-4114-b293-4fa576a900c3/jobs/10735) . This adds a symlink in the root folder to the `android` folder so we have the same sdkmanrc in both locations. An alternative would be to switch folders during the deploy job, but I wanted to keep it in the root folder if possible, seemed cleaner to me. Lmk if you think otherwise.
This was referenced Nov 14, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Nov 15, 2023
**This is an automatic release.** ### Dependency Updates * [AUTOMATIC] iOS 4.30.4 => 4.30.5 (#562) via RevenueCat Git Bot (@RCGitBot) * [AUTOMATIC] Android 7.2.2 => 7.2.3 (#560) via RevenueCat Git Bot (@RCGitBot) ### Other Changes * Improve circleci deploy automation (#559) via Toni Rico (@tonidero) * Fix deploy android circleci job (#558) via Toni Rico (@tonidero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #552, we added sdkman to install the correct java version. However, the deploy job in CircleCI runs in the root folder, as opposed to the test/lint jobs, which run in the
androidfolder, so it wasn't actually installing the correct java version because there was no.sdkmanrcfile in the root folder and was causing the deploy job to fail, as seen in PR 557 .This adds a symlink in the root folder to the
androidfolder so we have the same sdkmanrc in both locations.An alternative would be to switch folders during the deploy job, but I wanted to keep it in the root folder if possible, seemed cleaner to me. Lmk if you think otherwise.