Fix breaking change in objc in 7.4.0 #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
force-pushed
the
fix-breaking-change-7.4.0
branch
from
5749417
to
f1e5f6b
Compare
tonidero
commented
Nov 20, 2023
| @@ -22,7 +22,7 @@ import RevenueCat | |||
| usesStoreKit2IfAvailable: Bool = false, | |||
| dangerousSettings: DangerousSettings?, | |||
| shouldShowInAppMessagesAutomatically: Bool = true, | |||
| verificationMode: String? = nil) -> Purchases { | |||
| verificationMode: String?) -> Purchases { | |||
There was a problem hiding this comment.
The compiler didn't complain 😕 but I think this is needed to disambiguate both configure methods.
vegaro
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the old configure method after accidental breaking change introduced in 7.4.0