Add shouldDisplayDismissButton #606
Conversation
| @@ -26,13 +26,15 @@ import UIKit | |||
| } | |||
|
|
|||
| @objc | |||
| public func presentPaywall() { | |||
| public func presentPaywall( | |||
| displayCloseButton: Bool = false | |||
There was a problem hiding this comment.
I wonder if we should make it nullable instead? So we can use the default defined in purchases-ios
There was a problem hiding this comment.
Actually, not sure if that would work in objc, since nullable booleans didn't work well if I remember correctly
There was a problem hiding this comment.
I tried and I get
Method cannot be marked @objc because the type of the parameter cannot be represented in Objective-C
I can maybe do two functions?
There was a problem hiding this comment.
That's an option yeah... Maybe that would be better to try to avoid having the default in multiple places, but I'm ok keeping it like this as well.
| @@ -26,13 +26,15 @@ import UIKit | |||
| } | |||
|
|
|||
| @objc | |||
| public func presentPaywall() { | |||
| public func presentPaywall( | |||
There was a problem hiding this comment.
Should we add this to the api tests?
...id/hybridcommon-ui/src/main/java/com/revenuecat/purchases/hybridcommon/ui/PaywallFragment.kt
Show resolved
Hide resolved
|
I would change the label to |
ios/PurchasesHybridCommon/PurchasesHybridCommon/PaywallProxy.swift
Outdated
Show resolved
Hide resolved
Add shouldDisplayDismissButton to launchPaywall so we can add this parameter to the hybrids