Paywalls: disabled PaywallViewModes for now (#2874)

We won't ship these initially, but still leaving the infrastructure in place.
RevenueCat · Sep 14, 2023 · 7792581 · 7792581
1 parent 3bdc58c
commit 7792581
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 19 deletions.
diff --git a/RevenueCatUI/Data/PaywallViewMode.swift b/RevenueCatUI/Data/PaywallViewMode.swift
@@ -14,18 +14,18 @@ public enum PaywallViewMode {
     case fullScreen
 
     /// Paywall is displayed with a square aspect ratio. It can be embedded inside any other SwiftUI view.
+    @available(*, unavailable, message: "Other modes coming soon.")
     case card
 
     /// Paywall is displayed in a condensed format. It can be embedded inside any other SwiftUI view.
+    @available(*, unavailable, message: "Other modes coming soon.")
     case banner
 
     /// The default ``PaywallViewMode``: ``PaywallViewMode/fullScreen``.
     public static let `default`: Self = .fullScreen
 
 }
 
-extension PaywallViewMode: CaseIterable {}
-
 extension PaywallViewMode {
 
     var isFullScreen: Bool {

diff --git a/RevenueCatUI/Views/PurchaseButton.swift b/RevenueCatUI/Views/PurchaseButton.swift
@@ -132,12 +132,16 @@ struct PurchaseButton_Previews: PreviewProvider {
     }
 
     static var previews: some View {
-        ForEach(PaywallViewMode.allCases, id: \.self) { mode in
+        ForEach(Self.modes, id: \.self) { mode in
             Preview(mode: mode)
                 .previewLayout(.sizeThatFits)
         }
     }
 
+    private static let modes: [PaywallViewMode] = [
+        .fullScreen
+    ]
+
 }
 
 #endif
diff --git a/Tests/APITesters/RevenueCatUIAPITester/SwiftAPITester/PaywallViewAPI.swift b/Tests/APITesters/RevenueCatUIAPITester/SwiftAPITester/PaywallViewAPI.swift
@@ -18,7 +18,7 @@ struct App: View {
         PaywallView()
         PaywallView(mode: .fullScreen)
         PaywallView(offering: self.offering)
-        PaywallView(offering: self.offering, mode: .card)
+        PaywallView(offering: self.offering, mode: .fullScreen)
     }
 
     @ViewBuilder

diff --git a/Tests/RevenueCatUITests/BaseSnapshotTest.swift b/Tests/RevenueCatUITests/BaseSnapshotTest.swift
@@ -29,7 +29,11 @@ extension BaseSnapshotTest {
     static let purchaseHandler: PurchaseHandler = .mock()
 
     static let fullScreenSize: CGSize = .init(width: 460, height: 950)
+
+    // Disabled until we bring modes back.
+    /*
     static let cardSize: CGSize = .init(width: 460, height: 460)
     static let bannerSize: CGSize = .init(width: 380, height: 70)
+    */
 
 }
diff --git a/Tests/RevenueCatUITests/SinglePackagePaywallViewTests.swift b/Tests/RevenueCatUITests/SinglePackagePaywallViewTests.swift
@@ -16,6 +16,8 @@ class SinglePackagePaywallViewTests: BaseSnapshotTest {
         view.snapshot(size: Self.fullScreenSize)
     }
 
+    // Disabled until we bring modes back.
+    /*
     func testCardPaywall() {
         let view = PaywallView(offering: Self.offeringWithNoIntroOffer,
                                mode: .card,
@@ -35,6 +37,7 @@ class SinglePackagePaywallViewTests: BaseSnapshotTest {
 
         view.snapshot(size: Self.bannerSize)
     }
+    */
 
     func testSamplePaywallWithIntroOffer() {
         let view = PaywallView(offering: Self.offeringWithIntroOffer,

diff --git a/Tests/TestingApps/SimpleApp/SimpleApp/Views/AppContentView.swift b/Tests/TestingApps/SimpleApp/SimpleApp/Views/AppContentView.swift
@@ -43,18 +43,12 @@ struct AppContentView: View {
                     Text(verbatim: "You're signed in: \(info.originalAppUserId)")
                         .font(.callout)
 
-                    if self.shouldDisplayPaywall {
-                        PaywallView(mode: .banner)
-                    }
-
                     Spacer()
 
                     BarChartView(data: (0..<10).map { _ in Double.random(in: 0..<100)})
                         .frame(maxWidth: .infinity)
 
-                    if self.shouldDisplayPaywall {
-                        PaywallView(mode: .card)
-                    } else if let date = info.latestExpirationDate {
+                    if let date = info.latestExpirationDate {
                         Text(verbatim: "Your subscription expires: \(date.formatted())")
                             .font(.caption)
                     }
@@ -71,14 +65,6 @@ struct AppContentView: View {
         }
     }
 
-    private var displayNonFullScreenPaywalls: Bool {
-        return false
-    }
-
-    private var shouldDisplayPaywall: Bool {
-        return self.displayNonFullScreenPaywalls && self.customerInfo?.hasPro == false
-    }
-
 }