Paywalls: changed total_price_and_per_month to include period (#3044

) From beta feedback. This allows distinguishing subscriptions versus non-subscriptions.
RevenueCat · Sep 14, 2023 · 8f17e37 · 8f17e37
1 parent ac86cd6
commit 8f17e37
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/RevenueCatUI/Helpers/Package+VariableDataProvider.swift b/RevenueCatUI/Helpers/Package+VariableDataProvider.swift
@@ -48,7 +48,7 @@ extension Package: VariableDataProvider {
 
     func localizedPriceAndPerMonth(_ locale: Locale) -> String {
         if !self.isSubscription || self.isMonthly {
-            return self.localizedPrice
+            return self.localizedPricePerPeriod(locale)
         } else {
             let unit = Localization.abbreviatedUnitLocalizedString(for: .month, locale: locale)
             return "\(self.localizedPrice) (\(self.localizedPricePerMonth)/\(unit))"

diff --git a/Tests/RevenueCatUITests/Data/PackageVariablesTests.swift b/Tests/RevenueCatUITests/Data/PackageVariablesTests.swift
@@ -47,14 +47,14 @@ class PackageVariablesTests: TestCase {
 
     func testEnglishLocalizedPriceAndPerMonth() {
         expect(TestData.weeklyPackage.localizedPriceAndPerMonth(Self.english)) == "$1.99 ($7.96/mo)"
-        expect(TestData.monthlyPackage.localizedPriceAndPerMonth(Self.english)) == "$6.99"
+        expect(TestData.monthlyPackage.localizedPriceAndPerMonth(Self.english)) == "$6.99/mo"
         expect(TestData.annualPackage.localizedPriceAndPerMonth(Self.english)) == "$53.99 ($4.49/mo)"
         expect(TestData.lifetimePackage.localizedPriceAndPerMonth(Self.english)) == "$119.49"
     }
 
     func testSpanishLocalizedPriceAndPerMonth() {
         expect(TestData.weeklyPackage.localizedPriceAndPerMonth(Self.spanish)) == "$1.99 ($7.96/m.)"
-        expect(TestData.monthlyPackage.localizedPriceAndPerMonth(Self.spanish)) == "$6.99"
+        expect(TestData.monthlyPackage.localizedPriceAndPerMonth(Self.spanish)) == "$6.99/m."
         expect(TestData.annualPackage.localizedPriceAndPerMonth(Self.spanish)) == "$53.99 ($4.49/m.)"
         expect(TestData.lifetimePackage.localizedPriceAndPerMonth(Self.spanish)) == "$119.49"
     }

diff --git a/Tests/RevenueCatUITests/Data/VariablesTests.swift b/Tests/RevenueCatUITests/Data/VariablesTests.swift
@@ -143,6 +143,14 @@ class VariablesTests: TestCase {
         expect(result) == "$119.49"
     }
 
+    func testTotalPriceAndPerMonthForForMonthlyPackage() {
+        let result = VariableHandler.processVariables(
+            in: "{{ total_price_and_per_month }}",
+            with: TestData.monthlyPackage
+        )
+        expect(result) == "$6.99/mo"
+    }
+
     func testTotalPriceAndPerMonthForCustomMonthlyProductsReturnsPrice() {
         let result = VariableHandler.processVariables(
             in: "{{ total_price_and_per_month }}",
@@ -153,7 +161,7 @@ class VariablesTests: TestCase {
                 offeringIdentifier: ""
             )
         )
-        expect(result) == "$6.99"
+        expect(result) == "$6.99/mo"
     }
 
     func testTotalPriceAndPerMonthForCustomAnnualProductsReturnsPriceAndPerMonth() {