Paywalls: fixed error view being displayed on release builds (#3141)

Thanks @aboedo for catching this. I've also improved the API to avoid using `AnyView`.
RevenueCat · Sep 6, 2023 · 9bed1b0 · 9bed1b0
1 parent 3a6fe35
commit 9bed1b0
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 7 deletions.
diff --git a/RevenueCatUI/PaywallView.swift b/RevenueCatUI/PaywallView.swift
@@ -161,7 +161,7 @@ public struct PaywallView: View {
                 "You can fix this by editing the paywall in the RevenueCat dashboard.\n" +
                 "The displayed paywall contains default configuration.\n" +
                 "This error will be hidden in production.",
-                releaseBehavior: .replacement(AnyView(paywallView))
+                replacement: paywallView
             )
         } else {
             paywallView

diff --git a/RevenueCatUI/Views/DebugErrorView.swift b/RevenueCatUI/Views/DebugErrorView.swift
@@ -16,7 +16,7 @@ import SwiftUI
 
 /// A view that displays an error in debug builds
 @available(iOS 15.0, macOS 12.0, tvOS 15.0, *)
-struct DebugErrorView: View {
+struct DebugErrorView<Content: View>: View {
 
     private let description: String
     private let releaseBehavior: ReleaseBehavior
@@ -25,20 +25,20 @@ struct DebugErrorView: View {
 
         case emptyView
         case fatalError
-        case replacement(AnyView)
+        case replacement(Content)
 
     }
 
-    init(_ error: Error, releaseBehavior: ReleaseBehavior) {
+    init(_ error: Error, replacement content: Content) {
         self.init(
             (error as NSError).localizedDescription,
-            releaseBehavior: releaseBehavior
+            replacement: content
         )
     }
 
-    init(_ description: String, releaseBehavior: ReleaseBehavior) {
+    init(_ description: String, replacement content: Content) {
         self.description = description
-        self.releaseBehavior = releaseBehavior
+        self.releaseBehavior = .replacement(content)
     }
 
     var body: some View {
@@ -55,10 +55,14 @@ struct DebugErrorView: View {
                 #endif
 
             case let .replacement(view):
+                #if DEBUG
                 VStack {
                     self.errorView
                     view
                 }
+                #else
+                view
+                #endif
 
             case .fatalError:
                 #if DEBUG
@@ -90,3 +94,20 @@ struct DebugErrorView: View {
     }
 
 }
+
+@available(iOS 15.0, macOS 12.0, tvOS 15.0, *)
+extension DebugErrorView where Content == AnyView {
+
+    init(_ error: Error, releaseBehavior: ReleaseBehavior) {
+        self.init(
+            (error as NSError).localizedDescription,
+            releaseBehavior: releaseBehavior
+        )
+    }
+
+    init(_ description: String, releaseBehavior: ReleaseBehavior) {
+        self.description = description
+        self.releaseBehavior = releaseBehavior
+    }
+
+}