Paywalls: don't display "Purchases restored successfully" with no e…

…ntitlements We can improve the logic here, but this is a simple improvement for the obvious case where nothing was actually restored. We don't have an easy way to test this, but at least I added coverage for `onRestoreCompleted` which was missing.
RevenueCat · Sep 20, 2023 · 9c141a4 · 9c141a4
1 parent f54372b
commit 9c141a4
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/RevenueCatUI/Views/FooterView.swift b/RevenueCatUI/Views/FooterView.swift
@@ -167,8 +167,11 @@ private struct RestorePurchasesButton: View {
 
     var body: some View {
         AsyncButton {
-            _ = try await self.purchaseHandler.restorePurchases()
-            self.displayRestoredAlert = true
+            let customerInfo = try await self.purchaseHandler.restorePurchases()
+
+            if !customerInfo.entitlements.active.isEmpty {
+                self.displayRestoredAlert = true
+            }
         } label: {
             if #available(iOS 16.0, macOS 13.0, tvOS 16.0, *) {
                 ViewThatFits {

diff --git a/Tests/RevenueCatUITests/PurchaseCompletedHandlerTests.swift b/Tests/RevenueCatUITests/PurchaseCompletedHandlerTests.swift
@@ -70,6 +70,27 @@ class PurchaseCompletedHandlerTests: TestCase {
         expect(customerInfo).toEventually(be(TestData.customerInfo))
     }
 
+    func testOnRestoreCompleted() throws {
+        var customerInfo: CustomerInfo?
+
+        try PaywallView(
+            offering: Self.offering.withLocalImages,
+            customerInfo: TestData.customerInfo,
+            introEligibility: .producing(eligibility: .eligible),
+            purchaseHandler: Self.purchaseHandler
+        )
+            .onRestoreCompleted {
+                customerInfo = $0
+            }
+            .addToHierarchy()
+
+        Task {
+            _ = try await Self.purchaseHandler.restorePurchases()
+        }
+
+        expect(customerInfo).toEventually(be(TestData.customerInfo))
+    }
+
     private static let purchaseHandler: PurchaseHandler = .mock()
     private static let offering = TestData.offeringWithNoIntroOffer
     private static let package = TestData.annualPackage