Code review comments

RevenueCat · Apr 12, 2022 · e570b81 · e570b81
1 parent 7bdd49b
commit e570b81
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 15 deletions.
diff --git a/Tests/UnitTests/Networking/Backend/BackendGetCustomerInfoTests.swift b/Tests/UnitTests/Networking/Backend/BackendGetCustomerInfoTests.swift
@@ -125,13 +125,9 @@ class BackendGetCustomerInfoTests: BaseBackendTests {
 
         expect(result).toEventuallyNot(beNil())
 
-        switch result {
-        case .failure(.networkError(.decoding)):
-            // Correct result
-            break
-
-        default:
+        guard case .failure(.networkError(.decoding)) = result else {
             fail("Unexpected result: \(result!)")
+            return
         }
     }
 

diff --git a/Tests/UnitTests/Networking/Backend/BackendPostOfferForSigningTests.swift b/Tests/UnitTests/Networking/Backend/BackendPostOfferForSigningTests.swift
@@ -197,13 +197,10 @@ class BackendPostOfferForSigningTests: BaseBackendTests {
         }
 
         expect(receivedError).toEventuallyNot(beNil())
-        switch receivedError {
-        case .unexpectedBackendResponse(.postOfferIdSignature, _, _):
-            // Correct error
-            break
 
-        default:
+        guard case .unexpectedBackendResponse(.postOfferIdSignature, _, _) = receivedError else {
             fail("Invalid error: \(String(describing: receivedError))")
+            return
         }
     }
 

diff --git a/Tests/UnitTests/Networking/NetworkErrorTests.swift b/Tests/UnitTests/Networking/NetworkErrorTests.swift
@@ -161,6 +161,7 @@ class NetworkErrorTests: XCTestCase {
 
     // MARK: - Helpers
 
+    /// Stores the file/line information so expectation failures can point to the line creating the error.
     private func error(
         _ error: NetworkError,
         file: FileString = #file, line: UInt = #line

diff --git a/Tests/UnitTests/SubscriberAttributes/BackendSubscriberAttributesTestBase.swift b/Tests/UnitTests/SubscriberAttributes/BackendSubscriberAttributesTestBase.swift
@@ -131,11 +131,9 @@ class BackendSubscriberAttributesTestBase: XCTestCase {
         expect(receivedResult).to(beFailure())
 
         let error = try XCTUnwrap(receivedResult?.error)
-        switch error {
-        case .networkError(.decoding):
-            break // expected error
-        default:
+        guard case .networkError(.decoding) = error else {
             fail("Unexpected error: \(error)")
+            return
         }
     }