copy(with: VerificationResult): optimization to avoid copies

I noticed this could be improved while working on #2635.
RevenueCat · Jun 13, 2023 · f78fba4 · f78fba4
1 parent 06b0f3d
commit f78fba4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/Sources/Identity/CustomerInfo.swift b/Sources/Identity/CustomerInfo.swift
@@ -238,6 +238,8 @@ extension CustomerInfo {
 
     /// Creates a copy of this ``CustomerInfo`` modifying only the ``VerificationResult``.
     func copy(with entitlementVerification: VerificationResult) -> Self {
+        guard entitlementVerification != self.data.entitlementVerification else { return self }
+
         var copy = self.data
         copy.entitlementVerification = entitlementVerification
         return .init(data: copy)

diff --git a/Sources/Networking/HTTPClient/HTTPResponse.swift b/Sources/Networking/HTTPClient/HTTPResponse.swift
@@ -98,6 +98,8 @@ extension HTTPResponse {
     }
 
     func copy(with newVerificationResult: VerificationResult) -> Self {
+        guard newVerificationResult != self.verificationResult else { return self }
+
         return .init(
             statusCode: self.statusCode,
             responseHeaders: self.responseHeaders,