Update deprecations #1544
Update deprecations #1544
Conversation
Oh yeah definitely I don't think it's worth it. I'd keep the methods that require those for sure. Sorry I didn't realize that! I don't think the trade off is worth it. |
Sources/Misc/Deprecations.swift
Outdated
| * Enable debug logging. Useful for debugging issues with the lovely team @RevenueCat. | ||
| */ | ||
| @available(*, deprecated, message: "use Purchases.logLevel instead") | ||
| @objc static var debugLogsEnabled: Bool { |
There was a problem hiding this comment.
[not for this PR] I'm surprised the others in this file don't have @objc, did we miss that?
There was a problem hiding this comment.
made it for this PR 🤷 since the original work got undone anyway
Sources/Misc/Deprecations.swift
Outdated
| } | ||
|
|
||
| /** | ||
| * Deprecated |
There was a problem hiding this comment.
ooff I guess we missed adding docs for this one (before this PR)
Could we add a link to https://docs.revenuecat.com/docs/user-ids and maybe a comment like
| * Deprecated | |
| * Deprecated: Configure behavior through the RevenueCat dashboard instead. | |
| * Determines whether or not users may reuse a subscription from an App or Play Store account that already has that subscription active. | |
| * ### Related articles: | |
| * - https://docs.revenuecat.com/docs/user-ids |
Sources/Purchasing/Purchases.swift
Outdated
| @@ -226,7 +226,7 @@ public typealias StartPurchaseBlock = (@escaping PurchaseCompletedBlock) -> Void | |||
| private let productsManager: ProductsManager | |||
| private let customerInfoManager: CustomerInfoManager | |||
| private let trialOrIntroPriceEligibilityChecker: TrialOrIntroPriceEligibilityChecker | |||
| private let purchasesOrchestrator: PurchasesOrchestrator | |||
| internal let purchasesOrchestrator: PurchasesOrchestrator | |||
There was a problem hiding this comment.
Like I said, I don't think this is worth the tradeoff of moving these out 🙏🏻
…gs internal" This reverts commit eb2e57a.
| @@ -2182,42 +2182,6 @@ class PurchasesTests: XCTestCase { | |||
| expect(invokedMethodParams.appUserID) == identityManager.currentAppUserID | |||
| } | |||
|
|
|||
| func testAttributionDataDontSendNetworkAppUserIdIfNotProvided() throws { | |||
There was a problem hiding this comment.
Do these need to be removed now?
There was a problem hiding this comment.
i thought i was on the adservices branch 🤦♀️ reverted
This reverts commit 68a680d.
| @@ -33,7 +33,7 @@ public extension Purchases { | |||
| @available(watchOS, introduced: 6.2, deprecated: 1, renamed: "checkTrialOrIntroDiscountEligibility(productIdentifiers:)") | |||
| @available(macOS, introduced: 10.15, deprecated: 1, renamed: "checkTrialOrIntroDiscountEligibility(productIdentifiers:)") | |||
| @available(macCatalyst, introduced: 13.0, deprecated: 1, renamed: "checkTrialOrIntroDiscountEligibility(productIdentifiers:)") | |||
| func checkTrialOrIntroDiscountEligibility(_ productIdentifiers: [String]) async -> [String: IntroEligibility] { | |||
| @objc func checkTrialOrIntroDiscountEligibility(_ productIdentifiers: [String]) async -> [String: IntroEligibility] { | |||
There was a problem hiding this comment.
I'm confused, why do these need @objc? it's an async version (so Swift only), the non-async is above, and that one doesn't have @objc?
|
I think this can be closed now? |
As per discussion here, we should have a single place for deprecations.I'm not sure if it's worth making purchasesOrchestrator and that one post method internal, though. If it is, perhaps we want to add a note to make them private again once the functions are obsoleted. Opening a quick PR for discussion.Now this is just adding back @objc to functions and adding some docs