Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Integration Test for upgrading subscription with a different entitlement #1738

Closed
wants to merge 1 commit into from
Closed

Added Integration Test for upgrading subscription with a different entitlement #1738

wants to merge 1 commit into from

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jun 25, 2022 •
edited by jira bot
Loading

@NachoSoto NachoSoto requested a review from a team June 25, 2022 21:39
@NachoSoto
Copy link
Contributor Author

cc @joshdholtz

@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from 9d5ec76 to 715dca2 Compare June 25, 2022 21:43
NachoSoto
NachoSoto commented Jun 25, 2022
View reviewed changes
Tests/BackendIntegrationTests/StoreKitIntegrationTests.swift
.customerInfo
.entitlements

expect(entitlements.active).to(haveCount(1))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails with 2

Tests/BackendIntegrationTests/StoreKitIntegrationTests.swift
.entitlements

expect(entitlements.active).to(haveCount(1))
expect(entitlements[Self.entitlementIdentifier]?.isActive).to(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still active.

@NachoSoto
Copy link
Contributor Author

Looks like this is fixed: https://github.com/RevenueCat/khepri/pull/4165
Just waiting for it to be deployed to make sure this test passes now.

aboedo
aboedo approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd wait for @joshdholtz to also take a look before merging

@NachoSoto
Copy link
Contributor Author

NachoSoto commented Jun 30, 2022 •
edited
Loading

Supposedly the fix was deployed but this test is still failing :/ @joshdholtz any ideas?

The original entitlement is still being received as active.

@joshdholtz
Copy link
Member

joshdholtz commented Jun 30, 2022 •
edited
Loading

@NachoSoto Yeeaaaahhh, I re-ran it this morning and I saw that. Do these tests use the StoreKit Config file type of environment? Or are these like actual actual sandbox tests?

My tests on simulator and actual device didn't work but its having issues validating the receipt so I need to figure out what's going on there first 🙄

@NachoSoto
Copy link
Contributor Author

They do use a .storekit file yeah.

@NachoSoto
Copy link
Contributor Author

My tests on simulator and actual device didn't work but its having issues validating the receipt so I need to figure out what's going on there first

Are you using the correct API key?

@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from 715dca2 to 2a12817 Compare September 9, 2022 20:37
@NachoSoto NachoSoto added the test label Sep 9, 2022
@NachoSoto
Copy link
Contributor Author

I think this is the same as #1718.

@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch 2 times, most recently from 19c8b6f to c61d815 Compare September 28, 2022 20:40
@NachoSoto
Copy link
Contributor Author

NachoSoto commented Sep 28, 2022 •
edited by jira bot
Loading

Filed TRIAGE-124 to look into this.

@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from c61d815 to 48af962 Compare October 14, 2022 21:04
@NachoSoto
Copy link
Contributor Author

Just rebased this to see if #1965 could have fixed this, but alas no.

@NachoSoto NachoSoto removed the blocked label Dec 6, 2022
@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from 48af962 to 31be5b7 Compare December 6, 2022 02:06
@NachoSoto NachoSoto requested a review from a team December 6, 2022 02:06
@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from 31be5b7 to a912a85 Compare December 6, 2022 02:06
@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from a912a85 to 7e9d271 Compare December 13, 2022 16:27
@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from 7e9d271 to b3e23fc Compare June 16, 2023 17:30
@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from b3e23fc to b2859d2 Compare July 20, 2023 20:15
@NachoSoto NachoSoto force-pushed the integration-test-upgrade-entitlements branch from b2859d2 to 5a65d53 Compare July 21, 2023 06:44
@NachoSoto
Copy link
Contributor Author

@joshdholtz should we close this? It seems like this changed behavior isn't reflected in tests, not sure how much we care about this edge case.

@NachoSoto NachoSoto closed this Dec 7, 2023
@vegaro vegaro deleted the integration-test-upgrade-entitlements branch March 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboedo aboedo aboedo approved these changes

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NachoSoto @joshdholtz @aboedo