-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new fastlane internal plugin for automation #1779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So clean 👏🏻
@@ -1,278 +0,0 @@ | |||
before_all do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
../Tests/UnitTests/Info.plist, | ||
../Tests/UnitTestsHostApp/Info.plist | ||
" | ||
ENV["GITHUB_RELEASE_UPLOAD_ASSETS"] = "RevenueCat.framework.zip,RevenueCat.xcframework.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those wondering like me, this is defined inline now since it's only used in one place 👍🏻
f183d7e
to
dab692e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This is now final @RevenueCat/sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
@@ -1,278 +0,0 @@ | |||
before_all do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Description
This PR adds support for the new fastlane revenuecat internal plugin . Currently it will use the plugin for the
bump
,github_release
andprepare_next_version
lanes. Much of the logic has already been moved to the pluginTODO
Once plugin PRs have been merged:
github_release
lane. For this one, I will wait until a release is made to make sure it works).