Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfferingsManager: expose underlying error when ProductsManager returns an error #1792

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Aug 2, 2022

This will help figure out the reason behind #1765.
We were currently ignoring the error returned by ProductsManager.

In the example below, we can see the underlying issue is SKErrorDomain code 5.

Before:

Error fetching offerings - The operation couldn’t be completed. (RevenueCat.OfferingsManager.Error error 1.)

After:

Error fetching offerings - The operation couldn’t be completed. (RevenueCat.OfferingsManager.Error error 1.)
Underlying error: The operation couldn’t be completed. (SKErrorDomain error 5.)
ERROR: 😿‼️ There is an issue with your configuration. Check the underlying error for more details. There's a problem with your configuration. None of the products registered in the RevenueCat dashboard could be fetched from App Store Connect (or the StoreKit Configuration file if one is being used).
More information: https://rev.cat/why-are-offerings-empty

…turns an error

This will help figure out the reason behind #1765.
We were currently ignoring the error returned by `ProductsManager`.
Copy link
Contributor

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss, this is awesome. 🎈🐐

@NachoSoto NachoSoto merged commit 233e3a3 into main Aug 2, 2022
@NachoSoto NachoSoto deleted the offerings-manager-product-manager-error branch August 2, 2022 18:19
This was referenced Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants