Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CircleCI branch to prepare_next_version job #1796

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Aug 8, 2022

Description

This is a copy of the android PR RevenueCat/purchases-android#583. Basically with the changes to the fastlane plugin, I added a validation step that checked that the branch was main when creating the next snapshot PR. This actually shouldn't be like that since this job is executed from the tag. I removed the validation for this action in RevenueCat/fastlane-plugin-revenuecat_internal#12 but until that's merged, copying the fix from android here.

@tonidero tonidero requested a review from a team August 8, 2022 11:53
@tonidero tonidero added the ci label Aug 8, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@tonidero tonidero merged commit fa9d34f into main Aug 8, 2022
@tonidero tonidero deleted the pass-branch-from-circleci-to-prepare-next-version branch August 8, 2022 12:40
This was referenced Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants