Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdServices: Fix failing tests on main in iOS 12 and 13 - IOSAttributionPosterTests #1797

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

joshdholtz
Copy link
Member

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Fixed failing iOS 12 and 13 tests - https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7598/workflows/ba30c2e5-cae0-4a15-837a-8a972821a6b6

Description

Forgot to add try AvailabilityChecks.iOS14APIAvailableOrSkipTest() in IOSAttributionPosterTests

@joshdholtz joshdholtz requested a review from a team August 8, 2022 14:22
@joshdholtz joshdholtz added the test label Aug 8, 2022
Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshdholtz joshdholtz force-pushed the adservices-prevent-tests-ios-12-and-13 branch from 94813ef to 9677fb3 Compare August 8, 2022 14:52
@joshdholtz joshdholtz merged commit 6ef32be into main Aug 8, 2022
@joshdholtz joshdholtz deleted the adservices-prevent-tests-ios-12-and-13 branch August 8, 2022 15:02
This was referenced Aug 8, 2022
@NachoSoto
Copy link
Contributor

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants