Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PriceFormatterProvider: Sendable conformance and fixed thread-safety #1818

Merged
merged 3 commits into from
Aug 13, 2022
Merged

PriceFormatterProvider: Sendable conformance and fixed thread-safety #1818

merged 3 commits into from
Aug 13, 2022

Commits on Aug 13, 2022

  1. PriceFormatterProvider: Sendable conformance 

    This class was used all over the place but it wasn't thread-safe. The Swift compiler enforces this now that it conforms to Sendable (note it's not unchecked!).
Because `Atomic` guarantees correctness, this thread-safety can be enforced now by the compiler.
    @NachoSoto
    NachoSoto committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    8501033 View commit details
    Browse the repository at this point in the history

  2. Fixed Lock

    @NachoSoto
    NachoSoto committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    efece10 View commit details
    Browse the repository at this point in the history

  3. Added note

    @NachoSoto
    NachoSoto committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    3673e88 View commit details
    Browse the repository at this point in the history