Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.10.1 #1829

Closed
wants to merge 2 commits into from
Closed

Release 4.10.1 #1829

wants to merge 2 commits into from

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Aug 15, 2022

4.10.1

Bugfixes

…ds cached CustomerInfo value) (#1828)

* Log delegate set before sending custoemr info

* Force call delegate with customer info when being set

* Committed wrong file

* Moved to own method and added comments
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it (without merging) when tests pass

@joshdholtz
Copy link
Member Author

@aboedo Do I just close this PR then? 🤔

@aboedo
Copy link
Member

aboedo commented Aug 15, 2022

after tests pass and the tag is shipped, yes

@aboedo
Copy link
Member

aboedo commented Aug 15, 2022

@joshdholtz this is already out right? We can close this PR if that's the case

@joshdholtz
Copy link
Member Author

Ah yes, whoops! Thought I closed 🤦‍♂️ Thanks for reminder!

@joshdholtz joshdholtz closed this Aug 15, 2022
@vegaro vegaro deleted the release/4.10.1 branch August 16, 2022 14:36
@NachoSoto NachoSoto mentioned this pull request Aug 17, 2022
@NachoSoto
Copy link
Contributor

This should have been merged into main, right? We're missing this changelog.

@NachoSoto
Copy link
Contributor

I just manually added this changelog in #1848.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants