TrialOrIntroPriceEligibilityChecker: only use SK2 implementation if enabled
#1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled This used to always default to the SK2 implementation if it was available because it was much more reliable. However, as we've learned (#1893), it can be significantly slow. Until we implement caching for it ([CSDK-493]), this for now allows users to disable it if it's too slow. For users that don't specify `useSk2IfAvailable`, SK2 is now the new default, so this class will continue to use the "better" implementation for them too.
aboedo
approved these changes
Oct 14, 2022
NachoSoto
added a commit
that referenced
this pull request
Oct 24, 2022
**This is an automatic release.** ### Other Changes * `TrialOrIntroPriceEligibilityChecker`: only use SK2 implementation if enabled (#1984) via NachoSoto (@NachoSoto) Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com> Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #1894, but as a permanent change.
This used to always default to the SK2 implementation if it was available because it was much more reliable.
However, as we've learned (#1893), it can be significantly slow.
Until we implement caching for it (CSDK-493), this for now allows users to disable it if it's too slow.
For users that don't specify
useSk2IfAvailable, SK2 is now the new default, so this class will continue to use the "better" implementation for them too.