Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the link to StoreKit Config file from watchOS purchaseTester #2009

Merged

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Oct 28, 2022

It was pointing to an old file that's been since renamed

@aboedo aboedo self-assigned this Oct 28, 2022
@aboedo aboedo added the test label Oct 28, 2022
Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this locally myself and forgot to push it.

@NachoSoto
Copy link
Contributor

Missing this is making my Xcode crash now 🤦🏻‍♂️
I'm gonna merge it so I don't have to manually change it myself 😇

Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually hold on. Do you mind if we merge #1996 first?
I combined all targets and schemes into one.

@aboedo
Copy link
Member Author

aboedo commented Oct 28, 2022

go for it!

Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait this is the "normal" PurchaseTester, never mind.

@aboedo aboedo merged commit f0d7ee5 into main Oct 28, 2022
@aboedo aboedo deleted the fix/purchase_tester_watch_wrong_storekit_config_file_link branch October 28, 2022 19:19
@RCGitBot RCGitBot mentioned this pull request Nov 3, 2022
NachoSoto pushed a commit that referenced this pull request Nov 4, 2022
### New Features
* Introduced `PurchasesDiagnostics` to help diagnose SDK configuration
errors (#1977) via NachoSoto (@NachoSoto)
### Bugfixes
* Avoid posting empty receipts by making`TransactionsManager` always use
`SK1` implementation (#2015) via NachoSoto (@NachoSoto)
* `NetworkOperation`: workaround for iOS 12 crashes (#2008) via
NachoSoto (@NachoSoto)
### Other Changes
* Makes hold job wait for installation tests to pass (#2017) via Cesar
de la Vega (@vegaro)
* Update fastlane-plugin-revenuecat_internal (#2016) via Cesar de la
Vega (@vegaro)
* `bug_report.md`: changed SK2 wording (#2010) via NachoSoto
(@NachoSoto)
* Added `Set + Set` and `Set += Set` operators (#2013) via NachoSoto
(@NachoSoto)
* fix the link to StoreKit Config file from watchOS purchaseTester
(#2009) via Andy Boedo (@aboedo)
* `PurchaseTesterSwiftUI`: combined targets into one multi-platform and
fixed `macOS` (#1996) via NachoSoto (@NachoSoto)
* Less Array() (#2005) via SabinaHuseinova (@SabinaHuseinova)
* Docs: fixed `logIn` references (#2002) via NachoSoto (@NachoSoto)
* CI: use `Xcode 14.1` (#1992) via NachoSoto (@NachoSoto)
* `PurchaseTesterSwiftUI`: fixed warnings and simplified code using
`async` methods (#1985) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants