Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CachingProductsManager: use partial cached products #2014

Merged
merged 2 commits into from
Nov 8, 2022
Merged

CachingProductsManager: use partial cached products #2014

merged 2 commits into from
Nov 8, 2022

Commits on Nov 8, 2022

  1. CachingProductsManager: use partial cached products 

    #1907 introduced this `CachingProductsManager` abstraction, but simply copied the existing caching mechanism, which was very limited.
This expands on it by not ignoring cached products when not _all_ requested products are found. Instead, it uses the partial cache hit, and requests the rest of products.

This performance optimization is illustrated in the test change, as the second request only fetches the missing product now.
    @NachoSoto
    NachoSoto committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    aac1b0b View commit details
    Browse the repository at this point in the history

  2. Fixed invalid expectation

    @NachoSoto
    NachoSoto committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f2f3fa2 View commit details
    Browse the repository at this point in the history