customEntitlementsComputation: new method to switch users
#2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
reviewed
Apr 25, 2023
Examples/testCustomEntitlementsComputation/testCustomEntitlementsComputation/ContentView.swift
Outdated
Show resolved
Hide resolved
|
Just a heads up that I'm taking over this PR. Will address current comments first then test it manually and add unit tests. |
tonidero
reviewed
Apr 25, 2023
| /// with the newAppUserID. | ||
| /// | ||
| @objc(switchUserTo:) | ||
| func switchUser(to newAppUserID: String) { |
There was a problem hiding this comment.
It definitely feels some users might inadvertently use this method and it will error silently for them. I wonder if we should just crash if they are not in custom entitlement computation mode... Also, moving this to a different package could avoid this confusion.
|
Tested this manually and seems to work fine. Also added some unit tests though if we end up going with the approach of building a different package, we might have to move them as well... In any case, this is mostly final now. |
tonidero
force-pushed
the
andy/sdk-3082-update-login-so-that-it-doesnt-issue-a
branch
from
72e6157
to
41edbe0
Compare
tonidero
changed the base branch from
andy/sdk-3068-dangeroussetting-that-disables
to
andy/sdk-3068-dangeroussetting-that-disables_rebased
NachoSoto
approved these changes
Apr 25, 2023
tonidero
merged commit ea7b5d9
into
andy/sdk-3068-dangeroussetting-that-disables_rebased
tonidero
deleted the
andy/sdk-3082-update-login-so-that-it-doesnt-issue-a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method to switch users without posting to the backend for Custom Entitlements Computation mode.