SK2StoreProduct: simplify currencyCode extraction
#2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also look into exposing the |
aboedo
reviewed
May 15, 2023
|
|
||
| var _currencyCode: String { | ||
| if #available(iOS 16.0, tvOS 16.0, watchOS 9.0, macOS 13.0, *) { | ||
| // This is marked as `@_backDeploy`, but it's not actually working before iOS 16.0 |
There was a problem hiding this comment.
Actually I figured out the reason: this only works in whatever version of the SDK added this, but you can't use if it you're compiling with Xcode 13.x obviously... but the docs don't even say when it was added.
| @objc public var priceFormatter: NumberFormatter? { self.product.priceFormatter } | ||
| @objc public var priceFormatter: NumberFormatter { self.product.priceFormatter } |
There was a problem hiding this comment.
does this make it a breaking change?
There was a problem hiding this comment.
Yeah which is why I made it a feat. But I had to revert this to fix Xcode 13.x compilation 🤷🏻♂️
Won't matter in the long term since you can't submit apps with that anymore, but we need to keep support for it in CI until I finish #2421.
NachoSoto
force-pushed
the
sk2-currency-code
branch
from
3621fcd
to
b18891c
Compare
NachoSoto
force-pushed
the
sk2-currency-code
branch
2 times, most recently
from
c1d8ef5
to
875a31a
Compare
I noticed this new property thanks to [this tweet](https://twitter.com/ariskox/status/1658067009609904129?s=61&t=Zz639sMJdwHISm4AKYXoCw). ## Changes - Removed `SK2StoreProduct.jsonDict` - Obtaining `SK2StoreProduct.currencyCode` from [the new (backdeployed) property](https://developer.apple.com/documentation/storekit/product/4044347-priceformatstyle) - Thanks to that, `StoreProductType.priceFormatter` no longer needs to be `Optional` Because of that change, I'm making this a "feature" since it'll need a minor release, for users that are currently relying on that property being `Optional`.
NachoSoto
force-pushed
the
sk2-currency-code
branch
from
136e2da
to
39d2666
Compare
Codecov Report
@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
- Coverage 87.70% 87.59% -0.11%
==========================================
Files 197 197
Lines 13327 13338 +11
==========================================
- Hits 11689 11684 -5
- Misses 1638 1654 +16
|
|
This is ready now. |
aboedo
approved these changes
May 23, 2023
NachoSoto
added a commit
that referenced
this pull request
May 25, 2023
I noticed this new property thanks to [this tweet](https://twitter.com/ariskox/status/1658067009609904129?s=61&t=Zz639sMJdwHISm4AKYXoCw). This changes the "future" implementation of `SK2StoreProduct.currencyCode` to use [the new (backdeployed) property](https://developer.apple.com/documentation/storekit/product/4044347-priceformatstyle). We still need the existing implementation because `@_backDeploy` won't work if compiling with `Xcode 13.x`.
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this new property thanks to this tweet.
This changes the "future" implementation of
SK2StoreProduct.currencyCodeto use the new (backdeployed) property.We still need the existing implementation because
@_backDeploywon't work if compiling withXcode 13.x.