OfferingsManager: don't consider timeouts as configuration errors
#2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
offerings-manager-timeout-error
branch
from
e00debb
to
debf5bc
Compare
5 tasks
NachoSoto
force-pushed
the
offerings-manager-timeout-error
branch
from
debf5bc
to
9e35c47
Compare
NachoSoto
commented
May 15, 2023
| @@ -213,10 +219,11 @@ extension OfferingsManager: @unchecked Sendable {} | |||
|
|
|||
| extension OfferingsManager { | |||
|
|
|||
| enum Error: Swift.Error, Equatable { | |||
There was a problem hiding this comment.
This didn't need to be Equatable. Small but useful code size decrease in the SDK 💪🏻
NachoSoto
force-pushed
the
offerings-manager-timeout-error
branch
3 times, most recently
from
c847f8e
to
2d60e60
Compare
NachoSoto
force-pushed
the
offerings-manager-timeout-error
branch
from
2d60e60
to
0758d93
Compare
Codecov Report
@@ Coverage Diff @@
## main #2493 +/- ##
==========================================
+ Coverage 87.61% 87.68% +0.06%
==========================================
Files 197 197
Lines 13295 13305 +10
==========================================
+ Hits 11649 11667 +18
+ Misses 1646 1638 -8
|
tonidero
approved these changes
May 16, 2023
NachoSoto
added a commit
that referenced
this pull request
May 25, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2492.