Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests: added snapshot test for OfferingsResponse #2499

Merged
merged 2 commits into from
May 18, 2023
Merged

Integration Tests: added snapshot test for OfferingsResponse #2499

merged 2 commits into from
May 18, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented May 17, 2023 •
edited
Loading

Changes:

  • Added SnapshotTesting to BackendIntegrationTests target
  • Verify OfferingsResponse content with snapshots

This relies on the new serializable OfferingsResponse from #2495. It will make it trivial to verify the changes with the upcoming metadata in #2498.

@NachoSoto NachoSoto added the test label May 17, 2023
@NachoSoto NachoSoto requested review from joshdholtz and a team May 17, 2023 16:38
joshdholtz
joshdholtz approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Shiiippppp thhhhiiisssss

@NachoSoto NachoSoto force-pushed the offerings-integration-test-snapshot branch from 19977bd to 34b34a7 Compare May 17, 2023 17:10
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #2499 (72cd441) into main (aeb87ad) will decrease coverage by 0.04%.
The diff coverage is 93.80%.

❗ Current head 72cd441 differs from pull request most recent head 900d408. Consider uploading reports for the commit 900d408 to get more accurate results

@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
- Coverage   87.81%   87.77%   -0.04%     
==========================================
  Files         197      197              
  Lines       13425    13402      -23     
==========================================
- Hits        11789    11764      -25     
- Misses       1636     1638       +2
Impacted Files Coverage Δ
...urces/Networking/Responses/OfferingsResponse.swift 100.00% <ø> (ø)
Sources/Caching/DeviceCache.swift 94.03% <82.14%> (ø)
Sources/Purchasing/OfferingsManager.swift 93.00% <96.96%> (-0.09%) ⬇️
Sources/Logging/Strings/OfferingStrings.swift 94.33% <100.00%> (ø)
Sources/Purchasing/Offerings.swift 93.10% <100.00%> (ø)
Sources/Purchasing/OfferingsFactory.swift 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@NachoSoto NachoSoto force-pushed the nacho/sdk-3093-persist-offerings-cache-ios branch from 5f81928 to b962f15 Compare May 17, 2023 20:42
Base automatically changed from nacho/sdk-3093-persist-offerings-cache-ios to main May 17, 2023 23:21
@NachoSoto
Integration Tests: added snapshot test for OfferingsResponse
af338de 
### Changes:
- Added `SnapshotTesting` to `BackendIntegrationTests` target
- Verify `OfferingsResponse` content with snapshots

This relies on the new serializable `OfferingsResponse` from #2495. It will make it trivial to verify the changes with the upcoming metadata in #2498.
@NachoSoto
Updated snapshots
900d408
@NachoSoto NachoSoto force-pushed the offerings-integration-test-snapshot branch from 72cd441 to 900d408 Compare May 17, 2023 23:51
@NachoSoto NachoSoto enabled auto-merge (squash) May 17, 2023 23:51
@NachoSoto NachoSoto mentioned this pull request May 17, 2023
Merged
@NachoSoto NachoSoto merged commit 4fdeb6c into main May 18, 2023
@NachoSoto NachoSoto deleted the offerings-integration-test-snapshot branch May 18, 2023 00:10
@RCGitBot RCGitBot mentioned this pull request May 24, 2023
Closed
NachoSoto added a commit that referenced this pull request May 25, 2023
@NachoSoto
Integration Tests: added snapshot test for OfferingsResponse (#2499)
913c00e 
### Changes:
- Added `SnapshotTesting` to `BackendIntegrationTests` target
- Verify `OfferingsResponse` content with snapshots

This relies on the new serializable `OfferingsResponse` from #2495. It
will make it trivial to verify the changes with the upcoming metadata in
#2498.
@NachoSoto NachoSoto mentioned this pull request May 25, 2023
Closed
This was referenced May 31, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoSoto @joshdholtz