Perf: CustomerInfoManager.fetchAndCacheCustomerInfoIfStale no longer fetches data if stale
#2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o longer fetches data if stale Just a small performance optimization. No point calling `cachedCustomerInfo` if `isCacheStale`.
NachoSoto
changed the title
CustomerInfoManager.fetchAndCacheCustomerInfoIfStale no longer fetches data if staleCustomerInfoManager.fetchAndCacheCustomerInfoIfStale no longer fetches data if stale
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
==========================================
- Coverage 87.80% 87.79% -0.01%
==========================================
Files 197 197
Lines 13428 13427 -1
==========================================
- Hits 11790 11788 -2
- Misses 1638 1639 +1 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
May 19, 2023
NachoSoto
added a commit
that referenced
this pull request
May 25, 2023
…r fetches data if stale (#2508)
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small performance optimization. No point calling
cachedCustomerInfoifisCacheStale.