fix: (null) aliases
#255
Merged
fix: (null) aliases
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppUserID is null, to prevent the null alias
vegaro
reviewed
May 27, 2020
Purchases/Public/RCPurchasesErrors.h
Outdated
| @@ -52,7 +52,8 @@ typedef NS_ERROR_ENUM(RCPurchasesErrorDomain, RCPurchasesErrorCode) { | |||
| RCIneligibleError, | |||
| RCInsufficientPermissionsError, | |||
| RCPaymentPendingError, | |||
| RCInvalidSubscriberAttributesError | |||
| RCInvalidSubscriberAttributesError, | |||
| RCMissingAppUserIDError | |||
There was a problem hiding this comment.
We already have RCInvalidAppUserIdError, should we reuse that one? Maybe we can change the wording in RCInvalidAppUserIdError to be The app user id is not valid or it's missing.
There was a problem hiding this comment.
oops, totally missed that one! I'll use it instead
vegaro
approved these changes
May 28, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where if the appUserID is missing for whatever reason and you call createAlias, an alias to
(null)would be created.This fix makes the method no-op and return an error with a specific error code.
I was hesitant about adding the error code at first, but it's probably the best way to get developers to notice without sending the call to the backend.