Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Documentation: added reference to new View.debugRevenueCatOverlay #2574

Closed
wants to merge 2 commits into from

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented May 31, 2023

See #2567.

This requires a new flag include-extended-types (see https://apple.github.io/swift-docc-plugin/documentation/swiftdoccplugin/generating-documentation-for-extended-types/).

This is fixed in Xcode 15 🎉
Screenshot 2023-06-06 at 09 42 06

@NachoSoto NachoSoto added the docs label May 31, 2023
@NachoSoto NachoSoto requested a review from a team May 31, 2023 23:11
@NachoSoto
Copy link
Contributor Author

This is still not fully working, I filed swiftlang/swift-docc-plugin#60

@@ -25,6 +25,7 @@ Most features require configuring the SDK before using it.
- ``Purchases/configure(withAPIKey:)``
- ``Purchases/configure(with:)-6oipy``
- ``PurchasesDiagnostics``
- ``SwiftUI/View/debugRevenueCatOverlay()``
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to be able to do this.

@NachoSoto NachoSoto force-pushed the nacho/sdk-3152-purchase-tester-automatically-included-in-debug-mode branch 2 times, most recently from 51a4c45 to 8d323ed Compare June 2, 2023 18:40
@NachoSoto NachoSoto force-pushed the nacho/sdk-3152-purchase-tester-automatically-included-in-debug-mode branch 2 times, most recently from 17b242c to a53aef5 Compare June 6, 2023 21:21
@NachoSoto NachoSoto force-pushed the nacho/sdk-3152-purchase-tester-automatically-included-in-debug-mode branch 2 times, most recently from 04f0358 to fdc749b Compare June 7, 2023 01:10
Base automatically changed from nacho/sdk-3152-purchase-tester-automatically-included-in-debug-mode to main June 7, 2023 16:16
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #2574 (b6580dc) into main (3388bc5) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head b6580dc differs from pull request most recent head 22c4223. Consider uploading reports for the commit 22c4223 to get more accurate results

@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
+ Coverage   86.25%   86.27%   +0.02%     
==========================================
  Files         205      205              
  Lines       14366    14312      -54     
==========================================
- Hits        12391    12348      -43     
+ Misses       1975     1964      -11     

see 19 files with indirect coverage changes

@NachoSoto
Copy link
Contributor Author

TODO: add references for #2593 too.

@NachoSoto NachoSoto changed the title Documentation: added reference to new View.debugRevenueCatOverlay [WIP] Documentation: added reference to new View.debugRevenueCatOverlay Jun 9, 2023
@NachoSoto NachoSoto marked this pull request as ready for review October 24, 2023 14:59
@NachoSoto
Copy link
Contributor Author

Closing this

@NachoSoto NachoSoto closed this Nov 6, 2023
@NachoSoto NachoSoto deleted the swiftui-documentation branch November 6, 2023 16:35
@vegaro vegaro added pr:other and removed pr:docs labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants