Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: added iOS 17 job #2591

Merged
merged 1 commit into from
Jun 12, 2023
Merged

CI: added iOS 17 job #2591

merged 1 commit into from
Jun 12, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jun 6, 2023 •
edited
Loading

@NachoSoto NachoSoto added the ci label Jun 6, 2023
@NachoSoto NachoSoto requested a review from a team June 6, 2023 22:25
@NachoSoto NachoSoto marked this pull request as draft June 6, 2023 22:27
@NachoSoto
CI: added iOS 17 job
06561e2 
Note that this is still not ready in `CircleCI`.
@NachoSoto NachoSoto mentioned this pull request Jun 9, 2023
Merged
@NachoSoto NachoSoto removed the blocked label Jun 9, 2023
@NachoSoto NachoSoto marked this pull request as ready for review June 9, 2023 20:52
@NachoSoto NachoSoto enabled auto-merge (squash) June 9, 2023 20:59
@NachoSoto
Copy link
Contributor Author

I'd suggest merging that even though we still have some failures, so we can keep an eye until it's all resolved (I have a bunch of open PRs that solve them).

NachoSoto added a commit that referenced this pull request Jun 9, 2023
@NachoSoto
PaywallExtensions: fixed compilation
81af8db 
Not sure why I didn't notice this when compiling through Xcode, but just noticed this on CI in #2591.
Fixes:
```
❌ /Users/distiller/purchases-ios/Sources/Support/PaywallExtensions.swift:106:27: 'some' return types are only available in application extensions for iOS 13.0.0 or newer
    private var products: some Sequence<StoreProduct> {
```
tonidero
tonidero approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned about having tests not passing... even if it's to monitor them... Should we expect failures of them instead so we notice when they start passing? Though please ignore if tests are already passing with other PRs!

.circleci/config.yml
path: fastlane/test_output
- store_artifacts:
path: fastlane/test_output/xctest
destination: scan-test-output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extract this to be a command? Seems like it's almost repeated (with some small differences) for the other iOS versions... We can do that in a different PR though

@NachoSoto NachoSoto merged commit a4aaffc into main Jun 12, 2023
@NachoSoto NachoSoto deleted the xcode-15-ci branch June 12, 2023 07:34
NachoSoto added a commit that referenced this pull request Jun 12, 2023
@NachoSoto
PaywallExtensions: fixed compilation (#2613)
2036f9b 
Not sure why I didn't notice this when compiling through Xcode, but just
noticed this on CI in #2591.
Fixes:
```
❌ /Users/distiller/purchases-ios/Sources/Support/PaywallExtensions.swift:106:27: 'some' return types are only available in application extensions for iOS 13.0.0 or newer
    private var products: some Sequence<StoreProduct> {
```
@NachoSoto
Copy link
Contributor Author

Should we expect failures of them instead so we notice when they start passing

That's a good idea, is that a CircleCI thing?

NachoSoto added a commit that referenced this pull request Jun 12, 2023
@NachoSoto
CI: disable iOS 17 for now
0c2c674 
Basically disabling #2591. I didn't realize that we can't even run them because of the iOS 11 issue (I had tested changing that locally).
I filed SDK-3184 to drop support in the short term, but for now this disables those tests.
@NachoSoto NachoSoto mentioned this pull request Jun 12, 2023
Merged
NachoSoto added a commit that referenced this pull request Jun 13, 2023
@NachoSoto
CI: disable iOS 17 for now (#2627)
e76ee96 
Basically disabling #2591. I didn't realize that we can't even run them
because of the iOS 11 issue (I had tested changing that locally).
I filed SDK-3184 to drop support in the short term, but for now this
disables those tests.
This was referenced Jun 13, 2023
Closed
Merged
NachoSoto pushed a commit that referenced this pull request Jun 13, 2023
@RCGitBot
[AUTOMATIC] Release/4.22.0 (#2637)
aafdba1 
**This is an automatic release.**

### New Features
* New `DebugViewController`: UIKit counterpart for SwiftUI's
`debugRevenueCatOverlay` (#2631) via NachoSoto (@NachoSoto)
* Created `PaywallExtensions`: `StoreView` and `SubscriptionStoreView`
overloads for `Offering` (#2593) via NachoSoto (@NachoSoto)
* Introduced `debugRevenueCatOverlay()`: new SwiftUI debug overlay
(#2567) via NachoSoto (@NachoSoto)
### Bugfixes
* Removed `preventPurchasePopupCallFromTriggeringCacheRefresh`, update
caches on `willEnterForeground` (#2623) via NachoSoto (@NachoSoto)
* Fixed `Catalyst` build with `Xcode 15 beta 1` (#2586) via NachoSoto
(@NachoSoto)
### Dependency Updates
* Bump danger from 9.3.0 to 9.3.1 (#2592) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* `StoreTransaction`: added new `Storefront` to API testers (#2634) via
NachoSoto (@NachoSoto)
* `DebugView`: added snapshot tests (#2630) via NachoSoto (@NachoSoto)
* `verifyNoUnfinishedTransactions`/`verifyUnfinishedTransaction`: added
missing `#file` parameter (#2625) via NachoSoto (@NachoSoto)
* `PostReceiptDataOperation`: clean up cache key (#2628) via NachoSoto
(@NachoSoto)
* `PurchasesOrchestrator`: also get `Storefront` from SK1 (#2629) via
NachoSoto (@NachoSoto)
* `CI`: disable iOS 17 for now (#2627) via NachoSoto (@NachoSoto)
* `Tests`: fixed crash on iOS 13 (#2624) via NachoSoto (@NachoSoto)
* `StoreTransaction`: read `Storefront` from `StoreKit.Transaction`
(#2611) via NachoSoto (@NachoSoto)
* `StoreKitConfigTestCase`/`BaseStoreKitIntegrationTests`: also clear
transactions after every test (#2616) via NachoSoto (@NachoSoto)
* `ErrorCode.networkError`: improved description (#2610) via NachoSoto
(@NachoSoto)
* `PurchaseTester`: make CI job always point to current version (#2622)
via NachoSoto (@NachoSoto)
* Improved `finishAllUnfinishedTransactions` (#2615) via NachoSoto
(@NachoSoto)
* `StoreKitConfigTestCase`: improved `waitForStoreKitTestIfNeeded`
(#2614) via NachoSoto (@NachoSoto)
* `StoreKitConfigTestCase`: set `continueAfterFailure` to `false`
(#2617) via NachoSoto (@NachoSoto)
* `PaywallExtensions`: fixed compilation (#2613) via NachoSoto
(@NachoSoto)
* `CI`: added `iOS 17` job (#2591) via NachoSoto (@NachoSoto)
* `Encodable.jsonEncodedData`: fixed tests on iOS 17 due to inconsistent
key ordering (#2607) via NachoSoto (@NachoSoto)
* `debugRevenueCatOverlay`: added ability to display new
`SubscriptionStoreView` (#2595) via NachoSoto (@NachoSoto)
* Refactor: extracted all log strings (#2600) via NachoSoto (@NachoSoto)
* Changed tests to work around `URL` decoding differences in `iOS 17`
(#2605) via NachoSoto (@NachoSoto)
* Removed unnecessary `Strings.trimmedOrError` (#2601) via NachoSoto
(@NachoSoto)
* Fixed test compilation with `Xcode 15` (#2602) via NachoSoto
(@NachoSoto)
* Tests: added `iOS 17` snapshots (#2603) via NachoSoto (@NachoSoto)
* `StoreProductDiscount`: added `description` (#2604) via NachoSoto
(@NachoSoto)
* `debugRevenueCatOverlay` improvements (#2594) via NachoSoto
(@NachoSoto)
* `Xcode 15`: fixed all documentation warnings (#2596) via NachoSoto
(@NachoSoto)
* `StoreKitObserverModeIntegrationTests`: fixed and disabled SK2
`testPurchaseInDevicePostsReceipt` (#2589) via NachoSoto (@NachoSoto)
* `StoreKit2TransactionListener`: added log when receiving
`Transactions.Updates` (#2588) via NachoSoto (@NachoSoto)
* `Dictionary.MergeStrategy`: simplify implementation (#2587) via
NachoSoto (@NachoSoto)
* `Configuration.Builder`: fixed doc reference (#2583) via NachoSoto
(@NachoSoto)
* `APITesters`: available since iOS 11 (#2581) via NachoSoto
(@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
iOS 17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoSoto @tonidero