-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/watch os app #263
Merged
Merged
Feature/watch os app #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added assets
…red in the production location.
aboedo
commented
Jun 19, 2020
Comment on lines
16
to
27
|
||
#if TARGET_OS_WATCH | ||
// as of watchOS 6.2.8, there's a bug where the receipt is stored in the sandbox receipt location, | ||
// but the appStoreReceiptURL method returns the URL for the production receipt. | ||
// This code replaces "sandbox" with "receipt" as the last component of the receiptURL so that we get the | ||
// correct receipt. | ||
// This has been filed as radar FB7699277. More info in https://github.com/RevenueCat/purchases-ios/issues/207. | ||
NSString *receiptURLFolder = [[receiptURL absoluteString] stringByDeletingLastPathComponent]; | ||
NSURL *productionReceiptURL = [NSURL URLWithString:[receiptURLFolder stringByAppendingPathComponent:@"receipt"]]; | ||
receiptURL = productionReceiptURL; | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this workaround only works on Apple Watch and in Sandbox. I'm assuming that this would work correctly in production, since the whole problem is that the receipt gets stored in the production location anyway
vegaro
approved these changes
Jun 19, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FB7699277
, a bug where the sandbox receipt is stored where the production receipt should be.Review notes:
Most of the code here isn't particularly interesting. A lot of it is just boilerplate, including storyboards, and even the paywall is mostly ported over from the Swift example.
Interesting classes are:
RCReceiptFetcher
, which has the workaround for apple watchInterfaceController
, which has the interface for the watch app.