Trusted Entitlements: added tests to verify offerings and product entitlement mapping
#2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
reviewed
Jun 16, 2023
| @@ -154,15 +154,15 @@ extension HTTPRequest.Path { | |||
| case .getCustomerInfo, | |||
| .logIn, | |||
| .postReceiptData, | |||
| .getProductEntitlementMapping, | |||
There was a problem hiding this comment.
Hmm don't we need to align on the mechanism for signing these requests?
There was a problem hiding this comment.
Yeah I’m doing that separately. I thought these already had signing with nonces but no, that’s what tests are failing,
NachoSoto
changed the title
Offline Entitlements: added signature validation to entitlement mappingOffline Entitlements: added signature validation to entitlement mapping
NachoSoto
added a commit
that referenced
this pull request
Jun 30, 2023
### New format: - 32 bytes: intermediate public key - 4 bytes: Expiration (in days since epoch) - 64 bytes: intermediate public key signature, signed with the root private key - 16 bytes: salt - 64 bytes: payload signature: - salt - nonce (if present) - request time (as int string) - etag (if present) - payload This also adds support for optional nonces for "static" signatures, which is required for #2667.
NachoSoto
force-pushed
the
nacho/sdk-2989-add-signing-to-the-entitlementmapping-endpoint-ios
branch
from
21d22eb
to
4e85b64
Compare
NachoSoto
changed the title
Offline Entitlements: added signature validation to entitlement mappingTrusted Entitlements: added tests to verify offerings and product entitlement mapping
|
This is ready now. Didn't need to do any code changes 🎉 simply covered this behavior in tests. |
NachoSoto
commented
Jun 30, 2023
| self.backend.offlineEntitlements.getProductEntitlementMapping(withRandomDelay: false, | ||
| completion: completion) | ||
| self.backend.offlineEntitlements.getProductEntitlementMapping(withRandomDelay: false) { result in | ||
| completion(result.mapError(\.asPublicError)) |
There was a problem hiding this comment.
This was forwarding the wrong error.
tonidero
approved these changes
Jul 3, 2023
|
Mentioned this over Slack but I believe we need to add a check to make sure that, when verification is enabled and the signature is missing in offerings/product-entitlement-mapping, it fails to verify. Currently, since those requests won't have a nonce, it won't fail I believe. This change can be done in a different PR though. |
|
@tonidero thanks! Yeah, I'll do that in a separate PR. |
NachoSoto
force-pushed
the
nacho/sdk-2989-add-signing-to-the-entitlementmapping-endpoint-ios
branch
2 times, most recently
from
ab7562a
to
005db80
Compare
…ntitlement mapping These new integration tests verify that: 1. The response contains signature 2. In `enforced` mode, the signature must be valid 3. Response fails if it's not 4. In `informational` mode, no error is thrown
NachoSoto
force-pushed
the
nacho/sdk-2989-add-signing-to-the-entitlementmapping-endpoint-ios
branch
from
005db80
to
49cae7c
Compare
NachoSoto
deleted the
nacho/sdk-2989-add-signing-to-the-entitlementmapping-endpoint-ios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new integration tests verify that:
enforcedmode, the signature must be validinformationalmode, no error is thrown