Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: extract ErrorResponse into its own file #2697

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jun 22, 2023

I extracted this from #2698 to make it easier to review.

@NachoSoto NachoSoto requested a review from a team June 22, 2023 22:33
@NachoSoto NachoSoto force-pushed the nacho/changed-etag-signatures branch 7 times, most recently from 89e3fcd to 24cea0f Compare June 23, 2023 00:05
@NachoSoto NachoSoto changed the title [WIP] Trusted Entitlements: updated handling of 304 responses Refactor: extract ErrorResponse into its own file Jun 23, 2023
@NachoSoto NachoSoto changed the base branch from nacho/sdk-3164-ios-dont-parse-nonce-for-offerings-and-entitlement-mapping to main June 23, 2023 00:07
@NachoSoto NachoSoto force-pushed the nacho/changed-etag-signatures branch from 24cea0f to 99d297b Compare June 23, 2023 00:09
@NachoSoto NachoSoto marked this pull request as ready for review June 23, 2023 00:09
@NachoSoto NachoSoto enabled auto-merge (squash) June 23, 2023 14:41
@NachoSoto NachoSoto merged commit 984b231 into main Jun 23, 2023
@NachoSoto NachoSoto deleted the nacho/changed-etag-signatures branch June 23, 2023 14:53
tonidero pushed a commit that referenced this pull request Jun 26, 2023
**This is an automatic release.**

### Bugfixes
* Fix google play purchases missing purchase date (#2703) via Toni Rico
(@tonidero)
### Other Changes
* `PurchaseTester`: fixed `watchOS` build and ASC deployment (#2701) via
NachoSoto (@NachoSoto)
* Add `Data.sha1` (#2696) via NachoSoto (@NachoSoto)
* Refactor: extract `ErrorResponse` into its own file (#2697) via
NachoSoto (@NachoSoto)
* Add `Sequence<AdditiveArithmetic>.sum()` (#2694) via NachoSoto
(@NachoSoto)
* Refactored `Data.asString` implementation (#2695) via NachoSoto
(@NachoSoto)
* `Diagnostics`: new `FileHandler` for abstracting file operations
(#2673) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants