Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Entitlements: update handling of 304 responses #2698

Merged
merged 4 commits into from
Jun 30, 2023

Commits on Jun 30, 2023

  1. Trusted Entitlements: update handling of 304 responses

    - `ETagManager` no longer knows anything about signatures
    - `HTTPClient` loads cached response from `ETagManager` first before verifying signature with the cached body
    - Created new `VerifiedHTTPResponse`, which has the `VerificationResult`, extracted from `HTTPResponse`
    - Removed `VerificationResult.from(cache:response:)`
    - Updated `MockETagManager` to reflect behavior changed in #2666
    - Removed `ETagManager` tests about verification since they're no longer relevant
    - Removed several `HTTPClient` tests that were checking a behavior that was impossible (for example, no verification result despite it being enabled), or that checked behavior based on the cached `VerificationResult`
    NachoSoto committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    8e78737 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    02f9fa3 View commit details
    Browse the repository at this point in the history
  3. Using real ETagManager

    NachoSoto committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    0bf3c2b View commit details
    Browse the repository at this point in the history
  4. Added comment

    NachoSoto committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1876819 View commit details
    Browse the repository at this point in the history