Signing: extract and verify intermediate key
#2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
commented
Jun 26, 2023
| data: intermediatePublicKey)) | ||
|
|
||
| do { | ||
| return try Self.createPublicKey(with: intermediatePublicKey) |
There was a problem hiding this comment.
We considered caching this, but I just ran a benchmark on my device and the whole process (creating this key and verifying the original signature) takes 0.17 seconds.
There was a problem hiding this comment.
Sorry I meant 0.17ms!
NachoSoto
force-pushed
the
nacho/verify-intermediate-key
branch
from
52c5c76
to
0d1bd54
Compare
tonidero
reviewed
Jun 27, 2023
| } | ||
|
|
||
| guard let expirationDate = Self.extractAndVerifyIntermediateKeyExpiration(intermediateKeyExpiration) else { | ||
| return nil |
There was a problem hiding this comment.
So if the intermediate key is expired, we assume it's an attacker correct? As long as the backend makes sure this doesn't happen, this should be fine 👍
tonidero
reviewed
Jun 27, 2023
NachoSoto
force-pushed
the
nacho/changed-etag-signatures-2
branch
from
e9e2d8e
to
4d7e631
Compare
NachoSoto
force-pushed
the
nacho/verify-intermediate-key
branch
from
0d1bd54
to
7aa47ba
Compare
NachoSoto
force-pushed
the
nacho/changed-etag-signatures-2
branch
3 times, most recently
from
b4e4adc
to
dd41618
Compare
NachoSoto
force-pushed
the
nacho/verify-intermediate-key
branch
from
7aa47ba
to
4dc2d8a
Compare
NachoSoto
force-pushed
the
nacho/changed-etag-signatures-2
branch
7 times, most recently
from
fb1b4c9
to
7181dba
Compare
NachoSoto
force-pushed
the
nacho/verify-intermediate-key
branch
2 times, most recently
from
54b4e49
to
69a2415
Compare
|
Some tests seem to be failing though |
NachoSoto
force-pushed
the
nacho/changed-etag-signatures-2
branch
from
7181dba
to
ba53303
Compare
Yeah that's |
NachoSoto
force-pushed
the
nacho/changed-etag-signatures-2
branch
from
ba53303
to
1876819
Compare
NachoSoto
force-pushed
the
nacho/verify-intermediate-key
branch
from
69a2415
to
fcbc752
Compare
NachoSoto
force-pushed
the
nacho/verify-intermediate-key
branch
from
fcbc752
to
bef3bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last step of the new Signature format. Follow up to #2679 and #2698.
This reverts the public key change in #2679, since that was the intermediate key.
This now extracts the new intermediate public key from the signature, and verifies it using the public key.