Tests: fixed flaky failure with asynchronous check
#2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getCustomerInfo` call is asynchronous, so this expectation should be too.
Codecov Report
@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
+ Coverage 86.30% 86.47% +0.16%
==========================================
Files 214 214
Lines 15376 15376
==========================================
+ Hits 13271 13296 +25
+ Misses 2105 2080 -25 |
tonidero
approved these changes
Jul 11, 2023
NachoSoto
commented
Jul 11, 2023
| @@ -65,7 +65,7 @@ class PurchasesLogInTests: BasePurchasesTests { | |||
| self.identityManager.mockLogOutError = nil | |||
| self.backend.overrideCustomerInfoResult = .success(Self.mockLoggedOutInfo) | |||
|
|
|||
| expect(self.backend.getSubscriberCallCount) == 1 | |||
| expect(self.backend.getCustomerInfoCallCount).toEventually(equal(1)) | |||
There was a problem hiding this comment.
This is the only change
This was referenced Jul 11, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 11, 2023
**This is an automatic release.** ### New Features * `Trusted Entitlements`: (#2621) via NachoSoto (@NachoSoto) This new feature prevents MitM attacks between the SDK and the RevenueCat server. With verification enabled, the SDK ensures that the response created by the server was not modified by a third-party, and the entitlements received are exactly what was sent. This is 100% opt-in. `EntitlementInfos` have a new `VerificationResult` property, which will indicate the validity of the responses when this feature is enabled. ```swift let purchases = Purchases.configure( with: Configuration .builder(withAPIKey: "") .with(entitlementVerificationMode: .informational) ) let customerInfo = try await purchases.customerInfo() if !customerInfo.entitlements.verification.isVerified { print("Entitlements could not be verified") } ``` You can learn more from [the documentation](https://www.revenuecat.com/docs/trusted-entitlements). ### Other Changes * `TrustedEntitlements`: new `VerificationResult.isVerified` (#2788) via NachoSoto (@NachoSoto) * `Refactor`: extracted `Collection.subscript(safe:)` (#2779) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: added link to docs in `ErrorCode.signatureVerificationFailed` (#2783) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: improved documentation (#2782) via NachoSoto (@NachoSoto) * `Tests`: fixed flaky failure with asynchronous check (#2777) via NachoSoto (@NachoSoto) * `Integration Tests`: re-enable signature verification tests (#2744) via NachoSoto (@NachoSoto) * `CI`: remove `Jazzy` (#2775) via NachoSoto (@NachoSoto) * `Signing`: inject `ClockType` to ensure hardcoded signatures don't fail when intermediate key expires (#2771) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
NachoSoto
added a commit
that referenced
this pull request
Jul 12, 2023
Similar to #2786 and #2777. This test was verifying `getCustomerInfoCallCount`, but that gets updated asynchronously since #2533. The correct version waits for it to be updated, then ensures that it doesn't get updated again after logging out. Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/12762/workflows/a7e8c4ac-cecb-4c25-90ff-4390ed226bc4/jobs/88794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getCustomerInfocall is asynchronous, so this expectation should be too.I also renamed the old property name to "customer".