Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced FatalErrorUtil with Nimble #2802

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Replaced FatalErrorUtil with Nimble #2802

merged 1 commit into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Replaced FatalErrorUtil with Nimble

    Turns out that all the testing issues in CI with #2780 were due to these functions.
    
    /Users/ignacio/Desktop/Screenshot 2023-07-12 at 16.45.37.png
    Even though I wasn't able to reproduce the slowness, I was able to detect the root cause using Instruments, which detects this "severe hang".
    With this commit, all the slow test issues go away 🎉
    
    The only downside is we lose the ability to verify the assertion message.
    The benefit is we don't have to maintain that hacky code and instead rely on `Nimble` with a much better implementation that use this hack:
    ```swift
    func unreachable() {
        repeat {
            NSRunLoop.currentRunLoop().run()
        } while (true)
    }
    ```
    NachoSoto committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    85aa524 View commit details
    Browse the repository at this point in the history