CI: added workaround for Snapshots in Xcode Cloud
#2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
14 times, most recently
from
9eb5a1f
to
328d0e8
Compare
NachoSoto
commented
Jul 30, 2023
| "value" : "1" | ||
| }, | ||
| { | ||
| "key" : "XCODE_CLOUD", |
There was a problem hiding this comment.
New test plan to have this.
NachoSoto
commented
Jul 30, 2023
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "headers" : { | |||
There was a problem hiding this comment.
Some of these were missing.
NachoSoto
commented
Jul 30, 2023
| "Authorization" : "Bearer asharedsecret" | ||
| "Authorization" : "Bearer asharedsecret", | ||
| "X-Nonce" : "MTIzNDU2Nzg5MGFi", | ||
| "X-Post-Params-Hash" : "app_user_id,fetch_token:sha256:2cc3741ddb808ae6fd179f1398d9115b58772590765edf799ec778f929faa46d" |
There was a problem hiding this comment.
Some of these were outdated.
NachoSoto
commented
Jul 30, 2023
| func assertSnapshot(_ data: ProductRequestData, | ||
| testName: String = #function, | ||
| line: UInt = #line) { | ||
| SnapshotTesting.assertSnapshot( |
There was a problem hiding this comment.
This needed to call our overload now.
NachoSoto
commented
Jul 30, 2023
Comment on lines
+61
to
+72
| let ciPathPrefix = "/Volumes/workspace/repository/ci_scripts/" | ||
| let components = URL(string: file.description)!.pathComponents | ||
| let projectIndex = components.firstIndex(of: "repository")! | ||
| let folders = components[(projectIndex + 1)..<components.endIndex - 1].joined(separator: "/") | ||
| let fileName = (components[components.endIndex - 1] as NSString).deletingPathExtension | ||
|
|
||
| snapshotDirectory = "\(ciPathPrefix)\(folders)/__Snapshots__/\(fileName)" |
There was a problem hiding this comment.
Necessary for Xcode Cloud to be able to read snapshots.
NachoSoto
commented
Jul 30, 2023
| @@ -0,0 +1 @@ | |||
| ../Tests/ | |||
There was a problem hiding this comment.
Necessary for Xcode Cloud to have access to test snapshots.
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
from
328d0e8
to
774a42f
Compare
|
This is ready. |
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
3 times, most recently
from
6c95a98
to
774a42f
Compare
tonidero
approved these changes
Aug 3, 2023
|
I have no idea what's going on with Codecov :( |
|
Hmm tests seems to have passed, and codecov seems to have gotten stuck... Did you try rerunning tests? (seems like the last run was 6 days ago) |
|
Yeah I re-ran several times and tried increasing timeouts. No luck, so I filed a but with them: codecov/uploader#1126 |
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
2 times, most recently
from
fa4df3b
to
e5a94b2
Compare
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
from
e5a94b2
to
e80e540
Compare
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
from
e80e540
to
ac3aac7
Compare
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
from
ac3aac7
to
3f1eb2a
Compare
NachoSoto
force-pushed
the
xcode-cloud-snapshots
branch
from
9592ded
to
7190c95
Compare
This was referenced Oct 25, 2023
NachoSoto
added a commit
that referenced
this pull request
Oct 26, 2023
**This is an automatic release.** ### New Features * `PaywallColor`: change visibility of `Color.init(light:dark:)` to `private` (#3345) via NachoSoto (@NachoSoto) ### RevenueCatUI * `Paywalls`: new `.onPurchaseCompleted` overload with `StoreTransaction` (#3323) via NachoSoto (@NachoSoto) * `Paywalls`: finished template 5 (#3340) via NachoSoto (@NachoSoto) * `Paywalls`: new `onDismiss` parameter for `presentPaywallIfNeeded` (#3342) via NachoSoto (@NachoSoto) * `Paywalls`: disable shimmering on footer loading view (#3324) via NachoSoto (@NachoSoto) ### Bugfixes * `ErrorUtils.purchasesError(withSKError:)`: handle `URLError`s (#3346) via NachoSoto (@NachoSoto) ### Other Changes * `Paywalls`: add identifier to events (#3332) via Josh Holtz (@joshdholtz) * `Paywalls`: create new event session when paywall appears (#3330) via Josh Holtz (@joshdholtz) * `HTTPClient`: verbose logs for request IDs (#3320) via NachoSoto (@NachoSoto) * `Paywalls Tester`: fix `macOS` build (#3341) via NachoSoto (@NachoSoto) * `ProductFetcherSK1`: enable `TimingUtil` log (#3327) via NachoSoto (@NachoSoto) * `Paywall Tester`: fixed paywall presentation (#3339) via NachoSoto (@NachoSoto) * `CI`: replace Carthage build jobs with `xcodebuild` (#3338) via NachoSoto (@NachoSoto) * `Integration Tests`: use repetition count from test plan (#3329) via NachoSoto (@NachoSoto) * `Integration Tests`: new logs for troubleshooting flaky tests (#3328) via NachoSoto (@NachoSoto) * `CircleCI`: change iOS 17 job to use M1 Large resource (#3322) via NachoSoto (@NachoSoto) * `Paywalls Tester`: fix release build (#3321) via NachoSoto (@NachoSoto) * `Paywalls`: enable all iOS 17 tests (#3331) via NachoSoto (@NachoSoto) * `CI`: added workaround for Snapshots in `Xcode Cloud` (#2857) via NachoSoto (@NachoSoto) * `StoreKit 1`: disabled `finishTransactions` log on observer mode (#3314) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pointfreeco/swift-snapshot-testing#553.
Blocked by codecov/uploader#1126.