carthage_installation_tests: optimize SPM package loading
#3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
commented
Aug 31, 2023
| @@ -7,3 +7,15 @@ desc "Update carthage commit" | |||
| backup_extension = '.bck' | |||
| sh("sed", '-i', backup_extension, sed_regex, '../Cartfile') | |||
| end | |||
|
|
|||
| lane :installation_tests do | |||
| load_spm_dependencies | |||
There was a problem hiding this comment.
This is the core change, adding this which was introduced in #3119.
NachoSoto
changed the title
carthage_installation_tests: optimize SPM package loadingcarthage_installation_tests: optimize SPM package loading
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
==========================================
+ Coverage 86.60% 86.62% +0.01%
==========================================
Files 219 219
Lines 15713 15713
==========================================
+ Hits 13609 13611 +2
+ Misses 2104 2102 -2 ☔ View full report in Codecov by Sentry. |
NachoSoto
force-pushed
the
installation-tests-carthage-load-spm
branch
from
ea1da72
to
d9dedb6
Compare
tonidero
approved these changes
Sep 1, 2023
| lane :installation_tests do | ||
| load_spm_dependencies | ||
|
|
||
| Dir.chdir("..") do |
There was a problem hiding this comment.
Should this also use "#{File.dirname(__FILE__)}/../? I guess the circleci job already has the working_directory set, so it would probably work without this, but thinking in case we want to run this locally for any reason.
There was a problem hiding this comment.
If you run it locally you'd have to run it from Tests/InstallationTests/CarthageInstallation and then doing fastlane installation_tests. So I think it's fine to leave this as an implicitly relative path.
This was referenced Sep 5, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Sep 5, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
Follow up to #3119. This job also needed the workaround to make sure `Carthage` doesn't time out. Also moved the implementation to Fastlane.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3119. This job also needed the workaround to make sure
Carthagedoesn't time out.Also moved the implementation to Fastlane.