addresses a possible race condition with purchase completed callbacks #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Aug 11, 2020
Comment on lines
+1982
to
+1985
| self.purchases!.purchasePackage(package) { _,_,_,_ in | ||
| self.purchases!.purchasePackage(package) { (tx, info, error, userCancelled) in | ||
| receivedError = error as NSError? | ||
| secondCompletionCalled = true |
There was a problem hiding this comment.
this is the error case - while the completion block is running, it hasn't been removed from the list of completion blocks, and so initiating a new purchase will fail.
I confirmed that this test fails on develop
vegaro
approved these changes
Aug 11, 2020
Comment on lines
+1982
to
+1985
| self.purchases!.purchasePackage(package) { _,_,_,_ in | ||
| self.purchases!.purchasePackage(package) { (tx, info, error, userCancelled) in | ||
| receivedError = error as NSError? | ||
| secondCompletionCalled = true |
| @synchronized (self) { | ||
| completion = self.purchaseCompleteCallbacks[transaction.payment.productIdentifier]; | ||
| self.purchaseCompleteCallbacks[transaction.payment.productIdentifier] = nil; |
There was a problem hiding this comment.
thanks for fixing the productIdentifier thing, that was bad from me
| if (productIdentifier) { | ||
| self.purchaseCompleteCallbacks[productIdentifier] = nil; | ||
| } | ||
| } |
There was a problem hiding this comment.
It's funny, this is exactly what you said the other day that could break
aboedo
deleted the
fix/race_condition_with_purchase_completed_callbacks
branch
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition in
handleReceiptPostWithTransaction:purchaserInfo:subscriberAttributes:error:.The issue was that in the order of operations, we were:
If the completion block performed in 2. does something like initiate another purchase, it would access the callbacks list before it got removed in 3, and then the code would see that there's already a completion block for the product and return the
RCOperationAlreadyInProgressError.might address #291, but it's not guaranteed to since I'm not sure that this was the original issue.