Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paywalls: {{ price_per_period }} now takes SubscriptionPeriod.value into account #3133

Merged
merged 10 commits into from
Sep 1, 2023
Merged

Paywalls: {{ price_per_period }} now takes SubscriptionPeriod.value into account #3133

merged 10 commits into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. TestStoreProduct: new locale parameter 

    This allows overriding the `Locale` to be used for this test product, which is used to configure the price formatter.
This will be used by #3133.
    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    e5cd6dd View commit details
    Browse the repository at this point in the history

  2. Fixed Xcode 13

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1793c7e View commit details
    Browse the repository at this point in the history

  3. Paywalls: {{ price_per_period}} now takes `SubscriptionPeriod.val… 

    …ue` into account

This was incorrect for `PackageType.threeMonth` and `PackageType.sixMonth`.
    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4a1896b View commit details
    Browse the repository at this point in the history

  4. Added 2 month test

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    280d6b8 View commit details
    Browse the repository at this point in the history

  5. 2 more tests

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4750a3b View commit details
    Browse the repository at this point in the history

  6. More tests

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    122b55f View commit details
    Browse the repository at this point in the history

  7. Arabic tests

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9d49ccf View commit details
    Browse the repository at this point in the history

  8. Fixed tests

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4062666 View commit details
    Browse the repository at this point in the history

  9. Ignore RTL markers

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    66f5690 View commit details
    Browse the repository at this point in the history

  10. Fixed equalIgnoringRTL

    @NachoSoto
    NachoSoto committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9cf9f2b View commit details
    Browse the repository at this point in the history