Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: extract HealthOperation #3154

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

NachoSoto
Copy link
Contributor

Just a small refactor to make InternalAPI smaller, which will be expanded in future PRs.

Just a small refactor to make `InternalAPI` smaller, which will be expanded in future PRs.
@NachoSoto NachoSoto requested a review from a team September 6, 2023 23:15
@NachoSoto NachoSoto changed the title Extracted HealthOperation Refactor: extract HealthOperation Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8243593) 86.60% compared to head (e4f23df) 86.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3154   +/-   ##
=======================================
  Coverage   86.60%   86.61%           
=======================================
  Files         219      220    +1     
  Lines       15715    15715           
=======================================
+ Hits        13610    13611    +1     
+ Misses       2105     2104    -1     
Files Changed Coverage Δ
Sources/Networking/InternalAPI.swift 100.00% <ø> (ø)
...ources/Networking/Operations/HealthOperation.swift 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NachoSoto NachoSoto merged commit 0ea37c5 into main Sep 7, 2023
2 checks passed
@NachoSoto NachoSoto deleted the extract-health-operation branch September 7, 2023 14:18
NachoSoto pushed a commit that referenced this pull request Sep 14, 2023
**This is an automatic release.**

### Bugfixes
* Fix runtime crash in SK2TransactionListener in iOS < 15 (#3206) via
Toni Rico (@tonidero)
### Performance Improvements
* `OperationDispatcher`: add support for "long" delays (#3168) via
NachoSoto (@NachoSoto)
### Other Changes
* `Integration Tests`: add tests for ghost transfer behavior (#3135) via
NachoSoto (@NachoSoto)
* `Xcode`: removed `purchases-ios` SPM reference (#3166) via NachoSoto
(@NachoSoto)
* `Integration Tests`: another flaky failure (#3165) via NachoSoto
(@NachoSoto)
* `Integration Tests`: fix flaky test failure due to leftover
transaction (#3167) via NachoSoto (@NachoSoto)
* `Xcode 13`: removed last `Swift 5.7` checks (#3161) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improve flaky tests (#3163) via NachoSoto
(@NachoSoto)
* `Codable`: improved decoding errors (#3153) via NachoSoto (@NachoSoto)
* Refactor: extract `HealthOperation` (#3154) via NachoSoto (@NachoSoto)
* `Xcode 13`: remove conditional code (#3147) via NachoSoto (@NachoSoto)
* `CircleCI`: change all jobs to use `Xcode 14.x` and replace
`xcode-install` with `xcodes` (#2421) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants