Prevent unnecessary receipt posts #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transactions on the receipt
…ransactions, used it to decide whether or not to post the receipt
aboedo
commented
Aug 28, 2020
Comment on lines
+31
to
+36
| @objc public func receiptHasTransactions(receiptData: Data) -> Bool { | ||
| if let receipt = try? parse(from: receiptData) { | ||
| return receipt.inAppPurchases.count > 0 | ||
| } | ||
| // if the receipt can't be parsed, conservatively return true | ||
| return true |
There was a problem hiding this comment.
I'm not a huge fan of returning a Bool here, since there are technically three possible cases:
- true
- false
- unknown (receipt can't be parsed).
However, this isn't trivial to do in swift-objc interoperability:
- you can either use a
throws, which forces you to replace theBoolwithNSNumberor aninoutparam, and the caller has to pass in an error, and then unwrap theNSNumberor pass in theinoutparam - encode the return into an object that basically wraps a
Bool, then use that to encode the value.
They're not bad, but they did feel too complicated for what we're doing here.
More info: https://stackoverflow.com/a/36673027/5074358
There was a problem hiding this comment.
if you're curious about what this would look like, I have a stash that I can upload into a branch for perspective
| @@ -625,6 +630,15 @@ - (void)restoreTransactionsWithCompletionBlock:(nullable RCReceivePurchaserInfoB | |||
| CALL_IF_SET_ON_MAIN_THREAD(completion, nil, [RCPurchasesErrorUtils missingReceiptFileError]); | |||
| return; | |||
| } | |||
|
|
|||
| RCPurchaserInfo * _Nullable cachedPurchaserInfo = [self readPurchaserInfoFromCache]; | |||
There was a problem hiding this comment.
we'll move a lot of stuff out of this class eventually, but it's out-of-scope for this PR
Comment on lines
-43
to
+58
| let objectIdentifier = objectIdentifierParser.build(fromPayload: internalContainer.internalPayload) | ||
| let objectIdentifier = objectIdentifierBuilder.build(fromPayload: internalContainer.internalPayload) |
vegaro
approved these changes
Aug 28, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/revenuecat/story/70/ios-only-post-receipt-on-restore-if-there-are-transactions
Adds logic to check if a receipt has transactions, and if it doesn't, prevent an unnecessary post.
The one exception to the rule is if
purchaserInfois empty or it doesn't have anoriginalPurchaseDate, since that data is sometimes used to grandfather in subscribers.Requirements:
Tests