Paywalls: don't display "Purchases restored successfully" if nothings was restored
#3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntitlements We can improve the logic here, but this is a simple improvement for the obvious case where nothing was actually restored. We don't have an easy way to test this, but at least I added coverage for `onRestoreCompleted` which was missing.
aboedo
requested changes
Sep 20, 2023
RevenueCatUI/Views/FooterView.swift
Outdated
Comment on lines
172
to
174
| if !customerInfo.entitlements.active.isEmpty { | ||
| self.displayRestoredAlert = true | ||
| } |
There was a problem hiding this comment.
This might not be accurate - it assumes that the developer is using entitlements, which is encouraged but not required.
We should check nonSubscriptionTransactions as well
NachoSoto
changed the title
Paywalls: don't display "Purchases restored successfully" with no entitlementsPaywalls: don't display "Purchases restored successfully" if nothings was restored
NachoSoto
force-pushed
the
paywalls-restore-purchases-alert
branch
from
84edd09
to
b4da438
Compare
aboedo
approved these changes
Sep 20, 2023
Comment on lines
+170
to
+173
| let success = try await self.purchaseHandler.restorePurchases().success | ||
| if success { | ||
| self.displayRestoredAlert = true | ||
| } |
There was a problem hiding this comment.
this looks good to me as a stopgap, but I think we should try to get copy for saying something about "no purchases found" and localize it.
No-op is kind of an awkward experience to me
There was a problem hiding this comment.
Filed a Linear for this.
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can improve the logic here, but this is a simple improvement for the obvious case where nothing was actually restored.