Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename storekitconfig schemes #329

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Rename storekitconfig schemes #329

merged 2 commits into from
Sep 2, 2020

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Sep 2, 2020 •
edited
Loading

Before After
Screen Shot 2020-09-02 at 8 20 44 PM Screen Shot 2020-09-02 at 8 21 23 PM

I'm hoping that the new name will make it clearer for devs to understand their intent.

@aboedo aboedo self-assigned this Sep 2, 2020
@aboedo aboedo merged commit 5eb37fd into develop Sep 2, 2020
@aboedo aboedo deleted the rename_storekitconfig_schemes branch September 2, 2020 23:59
@aboedo aboedo added this to the 3.7.0 milestone Sep 16, 2020
@aboedo aboedo mentioned this pull request Sep 16, 2020
Merged
@aboedo aboedo mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegaro vegaro vegaro approved these changes

@mshmoustafa mshmoustafa Awaiting requested review from mshmoustafa

Assignees

@aboedo aboedo

Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aboedo @vegaro